GH-4242: Do not rewrite DISTINCT to REDUCED when ORDER BY is on an expression - #4245
Open
anishmehta24 wants to merge 1 commit into
Open
anishmehta24 wants to merge 1 commit into
anishmehta24 wants to merge 1 commit into
Conversation
… an expression TransformDistinctToReduced counted the variables of an ORDER BY expression as seen, as if ordering by STRLEN(?v) made equal values of ?v adjacent. It does not unless the expression is injective, so with ORDER BY STRLEN(?v) ?tag and ?tag not projected, REDUCED let duplicate ?v rows through. An expression over projected variables is still allowed in the ordering but no longer counts towards the projected variables having been seen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #4242
Pull request Description:
TransformDistinctToReducedrewritesDISTINCT+ORDER BYtoREDUCED+ORDER BYwhen the ordering makes equal projected rows adjacent. ItsisValidSortConditiontreated an ORDER BY expression like a plain variable: every variable mentioned by the expression was added toseenVars. Ordering bySTRLEN(?v)does not make equal values of?vadjacent (the function is not injective), so withORDER BY STRLEN(?v) ?tagand?tagunprojected, the rows("a",1) ("b",1) ("a",2)sort toa b aandREDUCEDreturns"a"twice.The change keeps allowing expressions over projected variables in the ordering (they do not break the property) but they no longer count towards "all projected variables seen"; only a projected variable ordered on directly does. So:
ORDER BY STRLEN(?v) ?tagandORDER BY STRLEN(?v)stayDISTINCT(newdistinct_to_reduced_14/15, both fail onmain).ORDER BY STRLEN(?v) ?v ?tagis still rewritten toREDUCED(newdistinct_to_reduced_16).testing/ARQ/Extra(distinct-order-expr), which fails onmainwith the duplicate row.TestOptDistinctReduced,TestOptimizerandScripts_ARQpass.TransformOrderByDistinctApplicationwas not touched: it only considers plain variables already.By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
🤖 Generated with Claude Code