testing/ostest: accept -ENOENT from work_cancel() for unqueued work - #3790
Merged
Merged
Conversation
Since nuttx commit 5a209a853e ("sched/wqueue: restore -ENOENT from
work_cancel() for unqueued work") work_cancel() and work_cancel_wq()
return -ENOENT when the work is not queued. The tester thread queues
work with zero delay, so the worker may already have consumed it by the
time it is cancelled and the ASSERT(ret == OK) fires;
Accept -ENOENT there and expect it when cancelling idle work in
the API validation test.
Signed-off-by: raiden00pl <raiden00@railab.me>
raiden00pl
requested review from
acassis,
cederom,
jerpelea and
xiaoxiang781216
September 17, 2026 07:38
xiaoxiang781216
approved these changes
Sep 17, 2026
Contributor
|
@acassis please merge this patch to unblock ci. |
acassis
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since nuttx commit 5a209a853e ("sched/wqueue: restore -ENOENT from work_cancel() for unqueued work") work_cancel() and work_cancel_wq() return -ENOENT when the work is not queued. The tester thread queues work with zero delay, so the worker may already have consumed it by the time it is cancelled and the ASSERT(ret == OK) fires;
Accept -ENOENT there and expect it when cancelling idle work in the API validation test.
Impact
fix CI
Testing
CI