pushConsumer add ssl - #765
Merged
Merged
Conversation
panzhi33
approved these changes
Feb 9, 2026
RockteMQ-AI
reviewed
Aug 27, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
This PR adds an sslEnabled property to the @RocketMQMessageListener annotation, allowing per-listener SSL configuration for the v5 client. The wiring through ListenerContainerConfiguration is correct.
One concern about the default value — see inline comment.
Automated review by github-manager-bot
| /** | ||
| * Enable or disable the use of Secure Sockets Layer (SSL) for network transport. | ||
| */ | ||
| boolean sslEnabled() default true; |
There was a problem hiding this comment.
[Warning] sslEnabled defaults to true. This may be a breaking change for existing users who do not have SSL configured — their listeners would suddenly fail to connect after upgrading.
Consider defaulting to false to preserve backward compatibility:
boolean sslEnabled() default false;Users who need SSL can explicitly opt in via @RocketMQMessageListener(sslEnabled = true).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.