Skip to content

Update tag - #770

Closed
zhaohai666 wants to merge 12 commits into
apache:masterfrom
zhaohai666:update-tag
Closed

Update tag#770
zhaohai666 wants to merge 12 commits into
apache:masterfrom
zhaohai666:update-tag

Conversation

@zhaohai666

Copy link
Copy Markdown
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

This reverts commit 756df0a.

# Conflicts:
#	rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/annotation/ExtConsumerResetConfiguration.java
#	rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/annotation/RocketMQMessageListener.java
#	rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/ExtConsumerResetConfiguration.java
#	rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/ListenerContainerConfiguration.java
#	rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/RocketMQAutoConfiguration.java
#	rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/RocketMQProperties.java
@zhaohai666 zhaohai666 closed this Mar 10, 2026
@RockteMQ-AI

Copy link
Copy Markdown

Issue Evaluation

Category: enhancement | Status: Evaluated

This appears to be a minor enhancement to update tag handling. The issue body is sparse — could you provide more details about what specifically needs to be updated?

Feasibility: needs more context
Scope: likely rocketmq-spring-boot-starter tag configuration


Automated evaluation by github-manager-bot

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Improves default filter configuration for v5 client consumers: sets default tag to * (subscribe all) and default filterExpressionType to TAG. Also improves Javadoc documentation. Good usability improvement.

Findings

  • [Warning] ExtConsumerResetConfiguration.java:75filterExpressionType() now returns hardcoded "TAG" instead of FILTER_EXPRESSION_TYPE_PLACEHOLDER. This means it no longer resolves the ${rocketmq.push-consumer.filterExpressionType:} property placeholder. If a user was relying on the property-based override for filterExpressionType, this change would silently ignore their configuration. Consider keeping the placeholder pattern: String FILTER_EXPRESSION_TYPE_PLACEHOLDER = "${rocketmq.push-consumer.filterExpressionType:TAG}"; and returning that instead.
  • [Info] RocketMQAutoConfiguration.java:600 — The null/empty check for filterExpressionType is a good defensive improvement. 👍

Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants