Update tag - #770
Closed
zhaohai666 wants to merge 12 commits into
Closed
Conversation
This reverts commit 756df0a. # Conflicts: # rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/annotation/ExtConsumerResetConfiguration.java # rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/annotation/RocketMQMessageListener.java # rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/ExtConsumerResetConfiguration.java # rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/ListenerContainerConfiguration.java # rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/RocketMQAutoConfiguration.java # rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/RocketMQProperties.java
|
Issue Evaluation Category: This appears to be a minor enhancement to update tag handling. The issue body is sparse — could you provide more details about what specifically needs to be updated? Feasibility: needs more context Automated evaluation by github-manager-bot |
RockteMQ-AI
reviewed
Aug 16, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Improves default filter configuration for v5 client consumers: sets default tag to * (subscribe all) and default filterExpressionType to TAG. Also improves Javadoc documentation. Good usability improvement.
Findings
- [Warning]
ExtConsumerResetConfiguration.java:75—filterExpressionType()now returns hardcoded"TAG"instead ofFILTER_EXPRESSION_TYPE_PLACEHOLDER. This means it no longer resolves the${rocketmq.push-consumer.filterExpressionType:}property placeholder. If a user was relying on the property-based override forfilterExpressionType, this change would silently ignore their configuration. Consider keeping the placeholder pattern:String FILTER_EXPRESSION_TYPE_PLACEHOLDER = "${rocketmq.push-consumer.filterExpressionType:TAG}";and returning that instead. - [Info]
RocketMQAutoConfiguration.java:600— The null/empty check forfilterExpressionTypeis a good defensive improvement. 👍
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.