Skip to content

Add default v5 client tag - #771

Merged
RongtongJin merged 5 commits into
apache:masterfrom
zhaohai666:Add-default-v5-client-tag
Mar 17, 2026
Merged

Add default v5 client tag#771
RongtongJin merged 5 commits into
apache:masterfrom
zhaohai666:Add-default-v5-client-tag

Conversation

@zhaohai666

Copy link
Copy Markdown
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin
RongtongJin merged commit 1eb3bed into apache:master Mar 17, 2026
2 of 3 checks passed
@RockteMQ-AI

Copy link
Copy Markdown

Issue Evaluation

Category: enhancement | Status: Evaluated

Feature request to add a default tag for the v5 client in rocketmq-spring. This would simplify tag-based message filtering configuration.

Feasibility: feasible
Scope: rocketmq-spring-boot-starter, v5 client configuration
Compatibility: additive change, backward compatible


Automated evaluation by github-manager-bot

@RockteMQ-AI

Copy link
Copy Markdown

Hi @zhaohai666, thanks for adding SQL92 filter support examples and default tag configuration.

A few things need attention:

  1. PR description is incomplete — The template placeholders (XXXXX) haven't been filled in. Please update with details about what the change does and how to verify it.

  2. This PR is 5 months old — Could you confirm this is still actively being worked on?

  3. Mixed concerns — This PR adds both sample code (SQL92 examples) and core changes (default tag in RocketMQMessageListener). Consider splitting into separate PRs for easier review.

Please update the PR description and we can proceed with review.


Automated notification by github-manager-bot

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Sets sensible defaults for v5 client tag (* = subscribe all) and filter expression type (tag), and adds SQL92 filter consumer/producer examples. Clean improvement.

Observations

  • [Info] Default tag change from empty to * is a good UX improvement — aligns with RocketMQ convention where * means "all tags".
  • [Info] SQL92 examples are well-documented with clear configuration instructions.
  • [Info] The SQL92ProducerApplication uses @SpringBootApplication as a standalone class rather than a sample within the existing demo app. This is fine for demonstration purposes.

LGTM — sensible defaults with helpful examples.


Automated review by github-manager-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants