Add default v5 client tag - #771
Conversation
|
Issue Evaluation Category: Feature request to add a default tag for the v5 client in rocketmq-spring. This would simplify tag-based message filtering configuration. Feasibility: feasible Automated evaluation by github-manager-bot |
|
Hi @zhaohai666, thanks for adding SQL92 filter support examples and default tag configuration. A few things need attention:
Please update the PR description and we can proceed with review. Automated notification by github-manager-bot |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Sets sensible defaults for v5 client tag (* = subscribe all) and filter expression type (tag), and adds SQL92 filter consumer/producer examples. Clean improvement.
Observations
- [Info] Default tag change from empty to
*is a good UX improvement — aligns with RocketMQ convention where*means "all tags". - [Info] SQL92 examples are well-documented with clear configuration instructions.
- [Info] The
SQL92ProducerApplicationuses@SpringBootApplicationas a standalone class rather than a sample within the existing demo app. This is fine for demonstration purposes.
LGTM — sensible defaults with helpful examples.
Automated review by github-manager-bot
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.