support simple consumer supports subscribing to multiple topics - #772
Conversation
|
Issue Evaluation Category: This is a feature request to support SimpleConsumer subscribing to multiple topics simultaneously. Currently, SimpleConsumer in rocketmq-spring is limited to single-topic subscription. Feasibility: feasible This aligns with the v5 client SDK SimpleConsumer design which already supports multi-topic consumption. The spring starter should expose this capability through configuration. Automated evaluation by github-manager-bot |
|
Hi @panzhi33, thanks for this contribution adding multi-topic subscription support for the simple consumer. A few things need attention before this can be reviewed:
Please update the PR description and we can proceed with a proper review. Automated notification by github-manager-bot |
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Extends SimpleConsumer configuration to support subscribing to multiple topics with per-topic filter expressions, replacing the previous single-topic limitation. Good architectural improvement.
Findings
- [Critical]
samples/pom.xml— duplicate module entry will break Maven build - [Warning] Module name typo: "muliti" → "multi"
- [Warning] No unit tests for the new multi-topic subscription logic
- [Warning] PR description contains placeholder text (XXXXX) — please fill in the actual change summary
Suggestions
- Fix the duplicate module entry in
samples/pom.xml - Add at least one unit test verifying multi-topic subscription configuration parsing
- Fill in the PR description with actual change details
Automated review by github-manager-bot
| <module>rocketmq-v5-client-consumer-simple-demo</module> | ||
| <module>rocketmq-v5-client-consumer-push-simple-demo</module> | ||
| </modules> | ||
| <module>rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo</module> |
There was a problem hiding this comment.
This module is listed twice — rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo appears on both line 38 and 39. This will cause a Maven build error (Malformed POM). Please remove the duplicate entry.
| <module>rocketmq-v5-client-consumer-simple-demo</module> | ||
| <module>rocketmq-v5-client-consumer-push-simple-demo</module> | ||
| </modules> | ||
| <module>rocketmq-v5-client-consume-simple-subscribe-muliti-topic-demo</module> |
There was a problem hiding this comment.
Typo in module name: muliti should be multi. Consider renaming the directory and module to rocketmq-v5-client-consume-simple-subscribe-multi-topic-demo.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.