Skip to content

THRIFT-6167: Fix PHP HTTP response framing in cross-tests - #3765

Merged
sveneld merged 1 commit into
apache:masterfrom
sveneld:THRIFT-6167
Sep 1, 2026
Merged

THRIFT-6167: Fix PHP HTTP response framing in cross-tests#3765
sveneld merged 1 commit into
apache:masterfrom
sveneld:THRIFT-6167

Conversation

@sveneld

@sveneld sveneld commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Fixes the remaining php->cpp HTTP cross-test failures on current master after THRIFT-6023 and THRIFT-6060 landed.

Changes:

  • add Content-Length to synchronous responses from test/php/HttpServer.php so the C++ HTTP client can consume PHP HTTP replies correctly
  • preserve the PHP launcher flags when test/php/HttpRouter.php execs into php -S
  • remove the now-passing php-cpp_{binary,compact,json}_http-ip cases from test/known_failures_Linux.json

Validation:

  • php->cpp HTTP: binary, compact, json
  • cpp->php HTTP: binary, compact, json, multi-binary, multic-compact, multij-json

JIRA: THRIFT-6167
Generated-by: OpenAI Codex GPT-5

  • Did you create an Apache Jira ticket? THRIFT-6167
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit?
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Client: cpp,php

Add Content-Length to synchronous PHP HTTP cross-test responses so the C++ HTTP client can read php->cpp replies correctly. Drop the passing php-cpp HTTP cases from known_failures_Linux.json.

Generated-by: OpenAI Codex GPT-5
@sveneld
sveneld marked this pull request as ready for review August 30, 2026 19:45
@sveneld
sveneld merged commit 3dece7e into apache:master Sep 1, 2026
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant