Repository navigation
Conversation
hiyufan
marked this pull request as ready for review
October 25, 2026 11:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Relax ONNX frontend rejects checker-valid
LpNormalizationmodels because no converter is registered.Compose existing Relax operators for L1 and L2 normalization. Honor the default
axis=-1andp=2, use absolute values for L1, and return zero for zero-norm slices. Float16/bfloat16 inputs accumulate and divide in float32 before casting back, avoiding overflow when squaring ordinary float16 values. Other input dtypes are preserved. Reject unsupported values ofp.Related to #20124 (LpNormalization only).
Validation on main
e345029c, Python 3.11, LLVM 21.1.8, ONNX 1.23.2 and ONNX Runtime 1.31.0:The NumPy L1 reference uses absolute values; ONNX 1.23.2's Python ReferenceEvaluator uses a signed sum for p=1, so it is not used as the oracle.
Prepared with OpenAI Codex assistance. The LLVM build and validation above were executed locally using the pinned TIRx/FFI sources.
CI status: Windows fails during Conda environment setup, before compilation or tests, with the same
conda init/Miniforge installation errors on unchanged main. This remains an outstanding validation gap; Jenkins checks are still pending.