Repository navigation
Conversation
hiyufan
marked this pull request as ready for review
October 25, 2026 11:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Relax ONNX frontend rejects
HannWindow,HammingWindowandBlackmanWindowmodels. Add shared cosine-sum lowering using existing Relax operators and the existing tensor-to-shape helper for runtime lengths.Support int32/int64 size inputs, initializer/runtime lengths, periodic/symmetric modes, the default float32 output and numeric output casts. Compute in float32, use ONNX's Hamming coefficients, and add the constant offset after the cosine terms to match native window-kernel rounding before integer casts. Validate the periodic attribute and positive initializer lengths.
Related to #20124 (these three window operators only).
Validation on main
e345029c, Python 3.11, LLVM 21.1.8, ONNX 1.23.2 and ONNX Runtime 1.31.0:test_range_constant_floatandtest_range_dynamic_scalar_inputs[-7.8--1.4-0.2-1-float32]. The Range converter is unchanged.Prepared with OpenAI Codex assistance. The LLVM build and validation above were executed locally using the pinned TIRx/FFI sources.