Repository navigation
Conversation
Nanmur
force-pushed
the
codex/fix-combine-parallel-matmul-const
branch
from
October 26, 2026 07:10
4127212 to
d625e2b
Compare
Contributor
Author
|
@tlopex Could you please help rerun the Windows check when the runner/setup issue is resolved? The Windows job has failed twice before any TVM build or test step ran (Actions runs 40280664426 and 40284167740). In both attempts,
The subsequent conda info, dependency installation, build, and test steps were skipped, so this failure did not exercise the PR changes. macOS, lint, and all Jenkins checks (arm/cpu/docker/gpu/wasm) are passing. I also cannot rerun the GitHub Actions job from a fork contributor account because it requires repository admin permission. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents CombineParallelMatmul from throwing when a matched matmul has a non-Var left operand.
The pass groups parallel branches by VarNode identity, so a constant left operand cannot participate in the existing grouping scheme. Skip these ineligible matches and leave the original matmul unchanged.
Fixes #20821
Tests:
The issue investigation and patch preparation were assisted by OpenAI Codex.