fix(annotations): clamp point annotation label x within chart bounds (Fixes #5106) - #5276
Open
waterWang wants to merge 1 commit into
Open
fix(annotations): clamp point annotation label x within chart bounds (Fixes #5106)#5276waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5106 — Point annotation labels near the left or right chart boundary are cut off when the label text extends beyond the chart area.
Problem
When a point annotation has a long label text and is positioned near the left or right edge of the chart, the label extends beyond the chart's grid bounds and gets clipped (hidden) by the SVG viewport.
Fix
Measure the label text width using before rendering, then clamp the label x position to keep it within the chart's grid boundaries:
Test
Added 3 new tests in the boundary-clamping describe block: