fix(symfony): drop translation command probe for object mapper (#8726)

* fix(symfony): drop translation command probe for object mapper

FrameworkBundle 8.2's TranslationExtractCommand extends a class of the optional symfony/translation
package, so probing it with class_exists() is a fatal error when that package is missing. The probe
only stood for "framework-bundle >= 7.3", which a composer conflict on <7.4 now guarantees, matching
the ^7.4 floor of every other Symfony dependency. Follows up #8627.

Fixes #8725

* test(symfony): guard object mapper gate test like the extension

Author: soyuka

composer.json

@@ -38,7 +38,7 @@
         "doctrine/orm": "<2.14.0 || 3.0.0",
         "doctrine/mongodb-odm": "<2.4",
         "doctrine/persistence": "<1.3",
-        "symfony/framework-bundle": "6.4.6 || 7.0.6",
+        "symfony/framework-bundle": "<7.4",
         "symfony/object-mapper": "<7.3.4",
         "symfony/var-exporter": "<6.1.1",
         "phpunit/phpunit": "<9.5",

src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -70,7 +70,6 @@
 use PHPStan\PhpDocParser\Parser\PhpDocParser;
 use Ramsey\Uuid\Uuid;
 use Symfony\AI\McpBundle\McpBundle;
-use Symfony\Bundle\FrameworkBundle\Command\TranslationExtractCommand as FrameworkTranslationExtractCommand;
 use Symfony\Bundle\FrameworkBundle\Controller\ControllerHelper;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\Config\Resource\DirectoryResource;
@@ -89,7 +88,6 @@
 use Symfony\Component\ObjectMapper\ObjectMapperInterface;
 use Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter;
 use Symfony\Component\Serializer\Normalizer\NumberNormalizer;
-use Symfony\Component\Translation\Command\TranslationExtractCommand;
 use Symfony\Component\Uid\AbstractUid;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Component\Yaml\Yaml;
@@ -210,10 +208,9 @@ public function load(array $configs, ContainerBuilder $container): void
         $this->registerLinkSecurityConfiguration($loader, $config);
         $this->registerJsonStreamerConfiguration($container, $loader, $formats, $config);
 
-        // TranslationExtractCommand was introduced in framework-bundle/7.3 with the object mapper service.
         // willBeAvailable mirrors FrameworkBundle's own gate: when symfony/object-mapper is in dev-only,
         // FrameworkBundle skips object_mapper.php and the "object_mapper" service we alias to does not exist.
-        if (class_exists(ObjectMapper::class) && (class_exists(TranslationExtractCommand::class) || class_exists(FrameworkTranslationExtractCommand::class)) && ContainerBuilder::willBeAvailable('symfony/object-mapper', ObjectMapperInterface::class, ['symfony/framework-bundle'])) {
+        if (class_exists(ObjectMapper::class) && ContainerBuilder::willBeAvailable('symfony/object-mapper', ObjectMapperInterface::class, ['symfony/framework-bundle'])) {
             $loader->load('state/object_mapper.php');
             $loader->load($config['use_symfony_listeners'] ? 'symfony/object_mapper.php' : 'state/object_mapper_processor.php');
         }

src/Symfony/Tests/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -40,8 +40,9 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\ObjectMapper\ObjectMapper;
+use Symfony\Component\ObjectMapper\ObjectMapperInterface;
 use Symfony\Component\Serializer\NameConverter\MetadataAwareNameConverter;
-use Symfony\Component\Translation\Command\TranslationExtractCommand;
 
 class ApiPlatformExtensionTest extends TestCase
 {
@@ -190,16 +191,20 @@ private function assertServiceHasTags(string $service, array $tags = []): void
 
     #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
-    public function testObjectMapperDoesNotLoadDeprecatedTranslationCommand(): void
+    public function testObjectMapperGateDoesNotAutoloadTranslationCommands(): void
     {
-        if (!class_exists(TranslationExtractCommand::class)) {
-            self::markTestSkipped('Requires the Symfony 8.2 translation command.');
-        }
+        spl_autoload_register(static function (string $class): void {
+            if ('Symfony\\Component\\Translation\\Command\\TranslationExtractCommand' === $class || FrameworkTranslationExtractCommand::class === $class) {
+                throw new \Error(\sprintf('Class "%s" must not be autoloaded.', $class));
+            }
+        }, true, true);
 
         (new ApiPlatformExtension())->load(self::DEFAULT_CONFIG, $this->container);
 
-        self::assertTrue($this->container->hasDefinition('api_platform.object_mapper.metadata_factory'));
-        self::assertFalse(class_exists(FrameworkTranslationExtractCommand::class, false));
+        self::assertSame(
+            class_exists(ObjectMapper::class) && ContainerBuilder::willBeAvailable('symfony/object-mapper', ObjectMapperInterface::class, ['symfony/framework-bundle']),
+            $this->container->hasDefinition('api_platform.object_mapper.metadata_factory')
+        );
     }
 
     public function testCommonConfiguration(): void

src/Symfony/composer.json

@@ -67,6 +67,9 @@
         "symfony/validator": "^7.4 || ^8.0",
         "webonyx/graphql-php": "^15.0"
     },
+    "conflict": {
+        "symfony/framework-bundle": "<7.4"
+    },
     "suggest": {
         "api-platform/doctrine-orm": "To support Doctrine ORM.",
         "api-platform/doctrine-odm": "To support MongoDB. Only versions 4.0 and later are supported.",