Repository navigation
fix(symfony): avoid deprecated translation command probe - #8627
Merged
Merged
Conversation
soyuka
force-pushed
the
fix/symfony-82-translation-probe
branch
from
October 2, 2026 13:55
dc7ccf1 to
eee8978
Compare
Member
|
thanks! |
bram123
pushed a commit
to bram123/core
that referenced
this pull request
Oct 12, 2026
2 tasks done
soyuka
added a commit
that referenced
this pull request
Oct 19, 2026
* fix(symfony): drop translation command probe for object mapper FrameworkBundle 8.2's TranslationExtractCommand extends a class of the optional symfony/translation package, so probing it with class_exists() is a fatal error when that package is missing. The probe only stood for "framework-bundle >= 7.3", which a composer conflict on <7.4 now guarantees, matching the ^7.4 floor of every other Symfony dependency. Follows up #8627. Fixes #8725 * test(symfony): guard object mapper gate test like the extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8626.
On Symfony 8.2, API Platform's object-mapper feature probe autoloads the deprecated FrameworkBundle TranslationExtractCommand shim. Probe the command's new Translation component namespace first, retaining the old FrameworkBundle class as a short-circuit fallback for earlier Symfony releases. Keep the existing object-mapper availability checks.
The regression test runs in a separate process, loads the real extension, verifies object-mapper metadata registration, and asserts the deprecated class was not loaded. It fails before the fix and passes afterward.
Validation using Symfony 8.2-dev dependencies: