Repository navigation
fix(state): restore 422 for empty scalar params - #8675
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #8344
ValueCasterthrew a 400 on an empty value, so?days=on an integerQueryParameterwith aChoiceconstraint answered 400 instead of the 422 it gave on 4.3. The caster now returns''as-is like any other value it can't cast (?days=foo), the constraint answers 422.Without a constraint
''would then reach SQL, so the ORM and ODMExactFilterignore an empty value (and drop empty list entries) when the parameter isn't string typed, that's the 4.3 behavior. A string parameter still filters on''. The empty value tests changed by #8344 are restored to their previous assertions.Note: Laravel's
EqualsFiltergets''again on a cast int parameter, same as 4.3.