Repository navigation
fix(metadata): Put::withAllowCreate() and Link::withFromProperty() return a new instance - #8685
Merged
soyuka merged 4 commits intoOct 16, 2026
Conversation
Maxcastel
marked this pull request as draft
October 14, 2026 14:58
Maxcastel
marked this pull request as ready for review
October 15, 2026 07:52
soyuka
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put::withAllowCreate()returnedvoidand changed the operation itself. With'defaults' => ['allow_create' => true]in the Laravel config, building the metadata fails:Link::withFromProperty()forgot theclonetoo.Tests:
testCreateWithAllowCreateDefault, and a newWithersTestthat calls everywith*()method of the metadata classes and checks it returns a new instance (these two were the only ones failing).