Repository navigation
fix(doctrine): accept resolved resources in links - #8687
Merged
Merged
Conversation
# Conflicts: # tests/Functional/Parameters/LinkProviderParameterTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
write_uri_variableon aReadLinkParameterProviderlink, the uri variable holds the resolved resource. The ORM and ODM links handlers bound it as a query parameter, so any Doctrine-backed link failed withObject of class ...Company could not be converted to string.The links handlers now read the link's identifiers off the resource when the uri variable is an instance of the link's class. Composite identifiers expand in place, so the positional consumption stays the same.
getIdentifierValue()is untouched, and so is the processor: it never receives the resolved resource, because the controller passes uri variables by value.The
instanceofguard matters: uri variables are already objects forUuid/Ulididentifiers (testGetRamseyUuidDummygoes 500 without it).Eloquent is not part of this: Laravel doesn't register
ReadLinkParameterProvider, so a resolved resource can't reach its links handler yet.