Repository navigation
fix(metadata): apply defaults that use a can* getter - #8691
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
soyuka
approved these changes
Oct 16, 2026
Member
|
my bad actually I thought this was targetting user classes good catch thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addGlobalDefaults()only looks for aget*method, butread,deserialize,validate,write,serializeandmapusecanRead(),canValidate()... So a default like'validate' => falsewas silently moved to the extra properties and did nothing.On Symfony this only changes
map, the bundle already moves the other keys toextra_propertiesbefore. On Laravel the defaults are passed as is, so all of them work now.