[Maxcastel]

Q	A
Branch?	5.0
License	MIT

With doctrine/orm 3, #[ORM\Column(options: ['default' => 'draft'])] didn't end up in the property metadata (so no default in the JSON Schema).

We support doctrine/orm 2 and 3:

core/src/Doctrine/Orm/composer.json

Line 32 in c33a566

"doctrine/orm": "^2.17 || ^3.3"

and the factory reads the column default differently for each one:

core/src/Doctrine/Orm/Metadata/Property/DoctrineOrmPropertyMetadataFactory.php

Lines 77 to 81 in c33a566

	if (class_exists(FieldMapping::class)) {
	$propertyMetadata = $propertyMetadata->withDefault($fieldMapping->default ?? $propertyMetadata->getDefault());
	} else {
	$propertyMetadata = $propertyMetadata->withDefault($fieldMapping['options']['default'] ?? $propertyMetadata->getDefault());
	}

Before

• doctrine/orm 2: $fieldMapping['options']['default'], works.

• doctrine/orm 3: $fieldMapping->default, which is deprecated since 3.6 and never filled by the attribute driver. So #[ORM\Column(options: ['default' => 'draft'])] gave no default in the property metadata, nor in the JSON Schema.

  The default property of Doctrine\ORM\Mapping\FieldMapping is deprecated and will be removed in 4.0. Instead, use FieldMapping::$options['default'].

After

doctrine/orm 3 reads options['default'] too, then default as a fallback, like Doctrine's SchemaTool does, so a mapping that sets it keeps working. It's not tied to 3.6, the bug is there on any doctrine/orm 3.

The existing test builds the FieldMapping by hand with ->default, so I added testCreateWithDefaultOptionFromColumnAttribute, which loads the real mapping with the AttributeDriver. Without the fix it fails on 3.3 and 3.6, and passes on 2.17, as expected.