Skip to content

fix(doctrine): require doctrine-common ^5.0.6 for ScalarValuesTrait - #8793

Open
Maxcastel wants to merge 1 commit into
api-platform:5.0from
Maxcastel:fix/doctrine-require-common-5-0-6
Open

Maxcastel wants to merge 1 commit into
api-platform:5.0from
Maxcastel:fix/doctrine-require-common-5-0-6

Conversation

@Maxcastel

Copy link
Copy Markdown
Contributor
Q A
Branch? 5.0
License MIT

The ORM and ODM search filters use ScalarValuesTrait since #8775, but it only exists in doctrine-common 5.0.x-dev, while both packages still require ^5.0.4:

"api-platform/doctrine-common": "^5.0.4",

That's why the lowest and minimal-changes jobs of doctrine-orm and doctrine-odm are red on 5.0. With --prefer-lowest (doctrine-common v5.0.4):

PHP Fatal error:  Trait "ApiPlatform\Doctrine\Common\Filter\ScalarValuesTrait" not found in .../Filter/StartSearchFilter.php on line 29

Once 5.0.6 is out, nothing would stop doctrine-orm 5.0.6 from being installed with doctrine-common 5.0.5 either.

Bumped to ^5.0.6 like #8675 did with ^4.4.5. These jobs stay red until 5.0.6 is tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant