Skip to content

Commit 00cfb65

Browse files
authored
perf: default gzip compression quality to 6 (#1099)
`GzipHttpCompressor` now defaults to quality 6 instead of 9. Level 6 is zlib's own default and what the JS client uses. Levels above 6 take about twice the CPU for request bodies roughly a percent smaller. Passing `quality=9` explicitly still works. Closes: #1095 *✍️ Drafted by Claude Code*
1 parent ba3827f commit 00cfb65

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

‎docs/02_concepts/13_http_compression.mdx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ client = ApifyClient(token='MY-APIFY-TOKEN', compression=IdentityCompressor())
146146
| **Availability** | Requires the `brotli` extra | Built-in, no extra needed |
147147
| **`Content-Encoding` header** | `br` | `gzip` |
148148
| **Quality range** | `0–11` | `1–9` |
149-
| **Default quality** | `6` | `9` |
149+
| **Default quality** | `6` | `6` |
150150
| **Enable via config** | `compression='brotli'` | `compression='gzip'` (default) |
151151
| **Best for** | Large payloads where bandwidth matters | Minimal-dependency environments |
152152

‎src/apify_client/http_compressors/_gzip.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class GzipHttpCompressor(HttpCompressor):
1919
_max_quality = 9
2020
"""Highest valid quality (slowest, best compression)."""
2121

22-
def __init__(self, *, quality: int = _max_quality) -> None:
22+
def __init__(self, *, quality: int = 6) -> None:
2323
"""Initialize the gzip compressor.
2424
2525
Args:

‎tests/unit/test_http_compressors.py‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import sys
77
from contextlib import contextmanager
88
from typing import TYPE_CHECKING
9+
from unittest.mock import Mock
910

1011
import brotli
1112
import pytest
@@ -59,6 +60,15 @@ def _affected(name: str) -> bool:
5960
sys.modules.update(saved)
6061

6162

63+
def test_gzip_compressor_defaults_to_quality_6(monkeypatch: pytest.MonkeyPatch) -> None:
64+
"""Gzip compressor uses compression level `6` when no quality is given."""
65+
compress = Mock(return_value=b'compressed')
66+
monkeypatch.setattr(gzip, 'compress', compress)
67+
68+
assert GzipHttpCompressor().compress(b'payload') == b'compressed'
69+
compress.assert_called_once_with(b'payload', compresslevel=6)
70+
71+
6272
@pytest.mark.parametrize(
6373
'quality',
6474
[

0 commit comments

Comments
 (0)