Skip to content

Commit c9c94c4

Browse files
authored
refactor: Use canonical /v2/actors/ path instead of legacy /v2/acts/ alias (#833)
Switches the actor resource client URLs from the legacy `/v2/acts/...` alias to the canonical `/v2/actors/...` family. Follow-up to [apify/apify-docs#2522](apify/apify-docs#2522) (and [apify/apify-core#27780](apify/apify-core#27780)), which made `/v2/actors/...` the documented canonical path while keeping `/v2/acts/...` as an undocumented alias. Non-breaking — the server still accepts the legacy alias, but the client should hit the canonical path.
1 parent 1f92625 commit c9c94c4

5 files changed

Lines changed: 19 additions & 19 deletions

File tree

‎src/apify_client/_resource_clients/actor.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def __init__(
7575
self,
7676
*,
7777
resource_id: str,
78-
resource_path: str = 'acts',
78+
resource_path: str = 'actors',
7979
**kwargs: Any,
8080
) -> None:
8181
super().__init__(
@@ -571,7 +571,7 @@ def __init__(
571571
self,
572572
*,
573573
resource_id: str,
574-
resource_path: str = 'acts',
574+
resource_path: str = 'actors',
575575
**kwargs: Any,
576576
) -> None:
577577
super().__init__(

‎src/apify_client/_resource_clients/actor_collection.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ActorCollectionClient(ResourceClient):
3636
def __init__(
3737
self,
3838
*,
39-
resource_path: str = 'acts',
39+
resource_path: str = 'actors',
4040
**kwargs: Any,
4141
) -> None:
4242
super().__init__(
@@ -215,7 +215,7 @@ class ActorCollectionClientAsync(ResourceClientAsync):
215215
def __init__(
216216
self,
217217
*,
218-
resource_path: str = 'acts',
218+
resource_path: str = 'actors',
219219
**kwargs: Any,
220220
) -> None:
221221
super().__init__(

‎tests/unit/test_actor_start_params.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def capture_request(request: Request) -> Response:
6464
)
6565

6666
httpserver.expect_request(
67-
f'/v2/acts/{_MOCKED_ACTOR_ID}/runs',
67+
f'/v2/actors/{_MOCKED_ACTOR_ID}/runs',
6868
method='POST',
6969
).respond_with_handler(capture_request)
7070

@@ -97,7 +97,7 @@ def capture_request(request: Request) -> Response:
9797
)
9898

9999
httpserver.expect_request(
100-
f'/v2/acts/{_MOCKED_ACTOR_ID}/runs',
100+
f'/v2/actors/{_MOCKED_ACTOR_ID}/runs',
101101
method='POST',
102102
).respond_with_handler(capture_request)
103103

@@ -130,7 +130,7 @@ def capture_request(request: Request) -> Response:
130130
)
131131

132132
httpserver.expect_request(
133-
f'/v2/acts/{_MOCKED_ACTOR_ID}/runs',
133+
f'/v2/actors/{_MOCKED_ACTOR_ID}/runs',
134134
method='POST',
135135
).respond_with_handler(capture_request)
136136

@@ -160,7 +160,7 @@ def capture_request(request: Request) -> Response:
160160
)
161161

162162
httpserver.expect_request(
163-
f'/v2/acts/{_MOCKED_ACTOR_ID}/runs',
163+
f'/v2/actors/{_MOCKED_ACTOR_ID}/runs',
164164
method='POST',
165165
).respond_with_handler(capture_request)
166166

@@ -191,7 +191,7 @@ def capture_request(request: Request) -> Response:
191191
)
192192

193193
httpserver.expect_request(
194-
f'/v2/acts/{_MOCKED_ACTOR_ID}/runs',
194+
f'/v2/actors/{_MOCKED_ACTOR_ID}/runs',
195195
method='POST',
196196
).respond_with_handler(capture_request)
197197

@@ -218,7 +218,7 @@ def capture_request(request: Request) -> Response:
218218
)
219219

220220
httpserver.expect_request(
221-
f'/v2/acts/{_MOCKED_ACTOR_ID}/runs',
221+
f'/v2/actors/{_MOCKED_ACTOR_ID}/runs',
222222
method='POST',
223223
).respond_with_handler(capture_request)
224224

‎tests/unit/test_client_errors.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -281,21 +281,21 @@ def test_actor_last_run_dataset_get_raises_on_404(httpserver: HTTPServer, sync_c
281281
"""404 covers missing actor, missing last_run, or missing dataset — all three are indistinguishable from the single
282282
HTTP response (the client only hits the final URL), so `NotFoundError` propagates uniformly.
283283
"""
284-
httpserver.expect_request('/v2/acts/actor-id/runs/last/dataset').respond_with_json(_not_found_body(), status=404)
284+
httpserver.expect_request('/v2/actors/actor-id/runs/last/dataset').respond_with_json(_not_found_body(), status=404)
285285
with pytest.raises(NotFoundError):
286286
sync_client.actor('actor-id').last_run().dataset().get()
287287

288288

289289
async def test_actor_last_run_dataset_get_raises_on_404_async(
290290
httpserver: HTTPServer, async_client: ApifyClientAsync
291291
) -> None:
292-
httpserver.expect_request('/v2/acts/actor-id/runs/last/dataset').respond_with_json(_not_found_body(), status=404)
292+
httpserver.expect_request('/v2/actors/actor-id/runs/last/dataset').respond_with_json(_not_found_body(), status=404)
293293
with pytest.raises(NotFoundError):
294294
await async_client.actor('actor-id').last_run().dataset().get()
295295

296296

297297
def test_actor_last_run_dataset_get_returns_dataset(httpserver: HTTPServer, sync_client: ApifyClient) -> None:
298-
httpserver.expect_request('/v2/acts/actor-id/runs/last/dataset').respond_with_json({'data': _DATASET_FIXTURE})
298+
httpserver.expect_request('/v2/actors/actor-id/runs/last/dataset').respond_with_json({'data': _DATASET_FIXTURE})
299299
dataset = sync_client.actor('actor-id').last_run().dataset().get()
300300
assert dataset is not None
301301
assert dataset.id == 'ds-1'
@@ -304,7 +304,7 @@ def test_actor_last_run_dataset_get_returns_dataset(httpserver: HTTPServer, sync
304304
async def test_actor_last_run_dataset_get_returns_dataset_async(
305305
httpserver: HTTPServer, async_client: ApifyClientAsync
306306
) -> None:
307-
httpserver.expect_request('/v2/acts/actor-id/runs/last/dataset').respond_with_json({'data': _DATASET_FIXTURE})
307+
httpserver.expect_request('/v2/actors/actor-id/runs/last/dataset').respond_with_json({'data': _DATASET_FIXTURE})
308308
dataset = await async_client.actor('actor-id').last_run().dataset().get()
309309
assert dataset is not None
310310
assert dataset.id == 'ds-1'

‎tests/unit/test_logging.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def mock_api(httpserver: HTTPServer) -> None:
171171
)
172172

173173
# Add actor info endpoint
174-
httpserver.expect_request(f'/v2/acts/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
174+
httpserver.expect_request(f'/v2/actors/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
175175
{
176176
'data': {
177177
'id': _MOCKED_ACTOR_ID,
@@ -203,7 +203,7 @@ def mock_api(httpserver: HTTPServer) -> None:
203203
)
204204

205205
# Add actor run creation endpoint
206-
httpserver.expect_request(f'/v2/acts/{_MOCKED_ACTOR_ID}/runs', method='POST').respond_with_json(
206+
httpserver.expect_request(f'/v2/actors/{_MOCKED_ACTOR_ID}/runs', method='POST').respond_with_json(
207207
{
208208
'data': status_generator._create_minimal_run_data('Initial message', 'RUNNING', is_terminal=False),
209209
}
@@ -520,7 +520,7 @@ async def test_streamed_log_async_restart_after_normal_completion(httpserver: HT
520520
)
521521

522522
# Set up actor info endpoint
523-
httpserver.expect_request(f'/v2/acts/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
523+
httpserver.expect_request(f'/v2/actors/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
524524
{
525525
'data': {
526526
'id': _MOCKED_ACTOR_ID,
@@ -608,7 +608,7 @@ async def test_status_message_watcher_async_restart_after_normal_completion(http
608608
)
609609

610610
# Set up actor info endpoint (needed for get_status_message_watcher)
611-
httpserver.expect_request(f'/v2/acts/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
611+
httpserver.expect_request(f'/v2/actors/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
612612
{
613613
'data': {
614614
'id': _MOCKED_ACTOR_ID,
@@ -749,7 +749,7 @@ def _register_run_and_actor_endpoints(httpserver: HTTPServer) -> None:
749749
}
750750
}
751751
)
752-
httpserver.expect_request(f'/v2/acts/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
752+
httpserver.expect_request(f'/v2/actors/{_MOCKED_ACTOR_ID}', method='GET').respond_with_json(
753753
{
754754
'data': {
755755
'id': _MOCKED_ACTOR_ID,

0 commit comments

Comments
 (0)