Skip to content

ci: Use latest Node patch release in setup-node - #1191

Merged
marcel-rbro merged 1 commit into
masterfrom
ci/node-check-latest
Nov 5, 2026
Merged

marcel-rbro merged 1 commit into
masterfrom
ci/node-check-latest

Conversation

@marcel-rbro

Copy link
Copy Markdown
Contributor

Why?

setup-node without check-latest uses the runner's cached Node release, which can lag behind security patches. The October 2026 Node.js security releases fix a high-severity Brotli decoder RCE (CVE-2026-111497) and TLS hostname verification issues across 22.x, 24.x, and 26.x (fixed in 22.23.4, 24.22.1, 26.12.1). The risk in CI is low, but release and publish jobs run with credentials, so this is worth the hygiene fix.

Same change as apify/apify-docs#3129.

What?

  • Add check-latest: true to all 4 setup-node steps (3 workflows), so CI resolves the newest patch release of each Node line

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@marcel-rbro marcel-rbro self-assigned this Nov 2, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.66%. Comparing base (25a64b6) to head (7a44042).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          61       61           
  Lines        6465     6465           
=======================================
  Hits         6185     6185           
  Misses        280      280           
Flag Coverage Δ
integration 91.43% <ø> (-0.04%) ⬇️
unit 90.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marcel-rbro
marcel-rbro requested a review from szaganek November 2, 2026 12:13
@marcel-rbro

Copy link
Copy Markdown
Contributor Author

Same fix as apify/apify-docs#3129, which was reviewed and approved by the Tooling team. This PR uses essentially the same approach: check-latest: true on the setup-node steps.

@marcel-rbro
marcel-rbro marked this pull request as ready for review November 3, 2026 15:21
@marcel-rbro
marcel-rbro merged commit 2681511 into master Nov 5, 2026
40 of 41 checks passed
@marcel-rbro
marcel-rbro deleted the ci/node-check-latest branch November 5, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants