Repository navigation
feat: add server_* arguments and deprecate actor_standby_* ones - #1202
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
+ Coverage 95.71% 95.74% +0.02%
==========================================
Files 62 63 +1
Lines 6656 6678 +22
==========================================
+ Hits 6371 6394 +23
+ Misses 285 284 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
November 5, 2026 10:33
janbuchar
approved these changes
Nov 5, 2026
actor_standby_* arguments to server_*server_* arguments and deprecate actor_standby_* ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
actor_standby_*arguments ofActorClient.update,ActorCollectionClient.create,TaskClient.update, andTaskCollectionClient.create(sync and async) to the Server Actor naming used byActorClient.server():actor_standby_is_enabledserver_is_enabledactor_standby_desired_requests_per_actor_runserver_desired_requests_per_actor_runactor_standby_max_requests_per_actor_runserver_max_requests_per_actor_runactor_standby_idle_timeoutserver_idle_timeoutactor_standby_buildserver_buildactor_standby_memory_mbytesserver_memory_mbytesactor_standby_disable_standby_fields_overrideserver_disable_fields_overrideactor_standby_should_pass_actor_inputserver_should_pass_actor_inputThe task methods take the five arguments they had before. The old names stay as deprecated aliases until v4, the same way as
build_taginvalidate_input(). Each one set emits aDeprecationWarningat the caller, and passing an alias together with its new name raises aValueError. All eight methods share one helper,build_actor_standby, which maps the aliases and builds theactorStandbyfield.actor_standby_tenancyfrom #1169 isn't on master yet, so it isn't covered here. #1169 can add it asserver_tenancydirectly, without an alias. It should ship in the same release as #1153.Closes: #1195
✍️ Drafted by Claude Code