Skip to content

chore: enable ruff G004 to keep f-strings out of logging calls - #1206

Merged
vdusek merged 1 commit into
masterfrom
refactor/lazy-log-formatting
Nov 6, 2026
Merged

vdusek merged 1 commit into
masterfrom
refactor/lazy-log-formatting

Conversation

@vdusek

@vdusek vdusek commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Removes Ruff's G004 from the ignore list, so logging calls with f-strings fail lint. The client already passes log values as %-style arguments everywhere, so no code changes are needed. The matching SDK change is in apify/apify-sdk-python.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 6, 2026
@vdusek vdusek self-assigned this Nov 6, 2026
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.74%. Comparing base (b1dd6c2) to head (311347f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          63       63           
  Lines        6678     6678           
=======================================
  Hits         6394     6394           
  Misses        284      284           
Flag Coverage Δ
integration 91.03% <ø> (+0.14%) ⬆️
unit 90.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review November 6, 2026 07:00
@vdusek
vdusek requested a review from apify-factory November 6, 2026 07:03

@apify-factory apify-factory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

🏭 Factory review — ℹ️ not auto-approved

This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.

check result
Static gates ❌ 15/16 — file-extensions
Review findings ✅ none
Reviewer escalation ✅ none
Juror 1 — claude-sonnet-5-5, adversarial ⏭️ skipped — a gate failed
Why it was not auto-approved

Failed gates:

  • file-extensions: disallowed extension: pyproject.toml

The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.

Reviewed 311347f42 · workflow run

@vdusek
vdusek requested a review from Pijukatel November 6, 2026 07:06
@vdusek
vdusek merged commit 32df309 into master Nov 6, 2026
43 of 44 checks passed
@vdusek
vdusek deleted the refactor/lazy-log-formatting branch November 6, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants