Repository navigation
fix: return non-JSON-document application/json* records as text in get_record() - #1215
Open
dheerajitbhu wants to merge 1 commit into
Open
dheerajitbhu wants to merge 1 commit into
dheerajitbhu wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1140
get_record()JSON-parsed everyapplication/json*content type, so a record saved asapplication/jsonl(orapplication/json-seq) could be written but not read back:response.json()failed and the client raisedInvalidResponseBodyError.Change
_parse_get_record_responsenow JSON-parses onlyapplication/jsonandapplication/json…+jsontypes (soapplication/json-patch+jsonkeeps returning a dict, as today).application/json*type, likeapplication/jsonlorapplication/json-seq, is returned as text, matching how the JS client returns these records.+jsontypes (string vs dict, as raised in the issue together with apify-client-js#1067) is left untouched on purpose.Tests
tests/unit/test_key_value_store.pycoverapplication/json,application/json; charset=utf-8,application/json-patch+json,application/jsonlandapplication/json-seqagainst the mock server. The jsonl and json-seq cases fail onmaster(8 failures across both HTTP clients) and pass with the fix.ruff check,ruff format --checkand the full unit suite (2627 passed) are green.Disclosure: I maintain a few Apify Store actors, and this change was prepared with AI assistance and reviewed and tested by me.