Repository navigation
Conversation
`StreamedLog` now flushes every complete line instead of holding the last message until the next one starts, matching the JS client. Lines of a multi-line message that arrive in a later chunk are redirected as a separate record at the level of the message they continue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ocuAJXagvBd6TZVvVAYzM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
- Coverage 95.76% 95.73% -0.03%
==========================================
Files 63 63
Lines 6676 6678 +2
==========================================
Hits 6393 6393
- Misses 283 285 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ocuAJXagvBd6TZVvVAYzM
Every line of a platform log starts with a timestamp, so a chunk never begins in the middle of a message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ocuAJXagvBd6TZVvVAYzM
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — pr-open-and-ready |
| Review findings | ✅ none |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
pr-open-and-ready: PR is a draft
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 70d3ae486 · workflow run
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
Redirecting on every newline can drop continuation lines of multi-line log messages, changing the redirected output.
| check | result |
|---|---|
| Static gates | ✅ 16/16 |
| Review findings | ✅ none |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
❌ reject |
Why it was not auto-approved
Juror 1 — claude-sonnet-5-5:
In src/apify_client/_streamed_log.py _log_buffer_content, a line is now treated as a complete message when its newline arrives, and each batch is split by the timestamp marker. Multi-line messages (e.g. tracebacks) have continuation lines with no timestamp. If such a line arrives in a later batch than its header line, it forms a batch with no marker, and re.split(...)[1:] discards it. Previously the continuation was part of the preceding message. This contradicts the claim that the redirected records are unchanged, and it also changes the public log output. Please handle continuation lines (e.g. keep the last message pending until a marker or end), add a test for a multi-line message split across chunks, and get a human review of the behavior change.
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 70d3ae486 · workflow run
StreamedLogredirects each line once its newline arrives instead of holding the last message until the next one starts, for parity with the newer JS implementation.