Repository navigation
Commit fe007cb
committed
test: address review findings (centralize RQ poll timeout, dedup get_run, bound webhook wait)
- Add an rq_poll_timeout fixture deriving the single/shared polling timeout
from the request_queue_apify param, replacing the derivation block that was
copy-pasted into all 20 request queue tests.
- Extract the byte-identical get_run closure in test_actor_charge.py into a
module-level _get_run helper used via functools.partial.
- Bound the webhook server Actor's wait loop (5s server timeout, 300s
deadline) so a webhook that never propagates fails the test quickly with an
empty WEBHOOK_BODY and a clear message instead of blocking until the run
timeout.1 parent ccda2ec commit fe007cb
4 files changed
Lines changed: 100 additions & 124 deletions
File tree
- tests
- e2e
- integration
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
393 | 393 | | |
394 | 394 | | |
395 | 395 | | |
| 396 | + | |
396 | 397 | | |
397 | 398 | | |
398 | 399 | | |
| |||
419 | 420 | | |
420 | 421 | | |
421 | 422 | | |
422 | | - | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
423 | 429 | | |
424 | 430 | | |
425 | 431 | | |
| |||
478 | 484 | | |
479 | 485 | | |
480 | 486 | | |
481 | | - | |
| 487 | + | |
482 | 488 | | |
483 | 489 | | |
484 | 490 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
21 | 27 | | |
22 | 28 | | |
23 | 29 | | |
| |||
116 | 122 | | |
117 | 123 | | |
118 | 124 | | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | 125 | | |
124 | 126 | | |
125 | 127 | | |
126 | | - | |
| 128 | + | |
127 | 129 | | |
128 | 130 | | |
129 | 131 | | |
| |||
139 | 141 | | |
140 | 142 | | |
141 | 143 | | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | 144 | | |
147 | 145 | | |
148 | 146 | | |
149 | | - | |
| 147 | + | |
150 | 148 | | |
151 | 149 | | |
152 | 150 | | |
| |||
164 | 162 | | |
165 | 163 | | |
166 | 164 | | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | 165 | | |
173 | 166 | | |
174 | 167 | | |
| |||
178 | 171 | | |
179 | 172 | | |
180 | 173 | | |
181 | | - | |
| 174 | + | |
182 | 175 | | |
183 | 176 | | |
184 | 177 | | |
| |||
199 | 192 | | |
200 | 193 | | |
201 | 194 | | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | 195 | | |
208 | 196 | | |
209 | 197 | | |
| |||
213 | 201 | | |
214 | 202 | | |
215 | 203 | | |
216 | | - | |
| 204 | + | |
217 | 205 | | |
218 | 206 | | |
219 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
97 | 114 | | |
98 | 115 | | |
99 | 116 | | |
| |||
0 commit comments