Repository navigation
Commit 3132135
committed
refactor!: make
Makes `RequestQueueClient.is_finished` abstract. The default fell back
to `is_empty`, which ignores requests still in progress, so a custom
client could report its queue as finished too early. All built-in
clients and the Apify SDK clients already implement the method. The v2
upgrade guide tells custom client authors to implement it.
Closes: #1985
*✍️ Drafted by Claude Code*RequestQueueClient.is_finished abstract (#2317)1 parent 0905964 commit 3132135
2 files changed
Lines changed: 5 additions & 9 deletions
File tree
- docs/06_upgrading
- src/crawlee/storage_clients/_base
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| 128 | + | |
128 | 129 | | |
129 | 130 | | |
130 | 131 | | |
131 | 132 | | |
132 | 133 | | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | 134 | | |
140 | 135 | | |
141 | 136 | | |
142 | | - | |
143 | | - | |
144 | | - | |
0 commit comments