Skip to content

Make the is_finished method abstract for RequestQueueClient #1985

Closed
#2317
Closed
Make the is_finished method abstract for RequestQueueClient#1985
#2317
Assignees
vdusek
Labels
t-toolingIssues with this label are in the ownership of the tooling team.
Milestone
2.0

Description

@Mantisus
Mantisus
opened on Jun 23, 2026

In the current implementation, the is_empty method is used by default for is_finished. This is a workaround designed to avoid breaking changes when the is_finished method was added.

This will be a breaking change.

Activity

  1. Mantisus
    added this to the 2.0 milestone on Jun 23, 2026
  2. github-actions
    added
    t-toolingIssues with this label are in the ownership of the tooling team.
    on Jun 23, 2026
  3. vdusek
    changed the title [-]Make the `is_finished` method abstract for `RequestQueueClient`.[/-] [+]Make the `is_finished` method abstract for `RequestQueueClient`[/+] on Jul 3, 2026
  4. vdusek
    linked a pull request that will close this issuerefactor!: make `RequestQueueClient.is_finished` abstract #2317on Oct 13, 2026
  5. vdusek
    self-assigned this
    on Oct 13, 2026
  6. vdusek
    added a commit that references this issue on Oct 13, 2026

    refactor!: make `RequestQueueClient.is_finished` abstract (#2317)

    07bb164

  7. vdusek commented on Oct 13, 2026

    @vdusek
    vdusek
    on Oct 13, 2026
    Collaborator

    resolved by #2317

  8. vdusek
    closed this as completedon Oct 13, 2026
  9. vdusek
    added a commit that references this issue on Oct 16, 2026

    refactor!: make `RequestQueueClient.is_finished` abstract (#2317)

    eaac28b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

t-toolingIssues with this label are in the ownership of the tooling team.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions