Skip to content

fix: Use max() instead of min() for request_max_duration statistic #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
Jan 30, 2026
Merged

fix: Use max() instead of min() for request_max_duration statistic #1701

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee576ea
fix: Use max() instead of min() for request_max_duration statistic
vdusek Jan 30, 2026
e137730
test: Add unit test for request_max_duration tracking
vdusek Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/statistics/_statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ def record_request_processing_finish(self, request_id_or_key: str) -> None:
state.request_min_duration = min(
state.request_min_duration if state.request_min_duration is not None else timedelta.max, duration
)
state.request_max_duration = min(
state.request_max_duration = max(
state.request_max_duration if state.request_max_duration is not None else timedelta(), duration
)

Expand Down
Loading