Repository navigation
test: use spawn context for ProcessPoolExecutor in basic crawler tests - #2276
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2276 +/- ##
=======================================
Coverage 93.90% 93.91%
=======================================
Files 182 182
Lines 13144 13144
=======================================
+ Hits 12343 12344 +1
+ Misses 801 800 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 5, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state persistence tests in
test_basic_crawler.pystartProcessPoolExecutorwith the default fork start method. On Linux with Python 3.12 and 3.13, forking a multi-threaded process emitsDeprecationWarning: This process is multi-threaded, use of fork() may lead to deadlocks in the child.The executors now passmp_context=get_context('spawn').Each spawned worker imports
crawlee.crawlersagain, which adds a few seconds to each of the two tests. Windows (spawn) and Python 3.14 (forkserver) already pay that cost.Closes #2273
✍️ Drafted by Claude Code