Repository navigation
refactor!: make RequestQueueClient.is_finished abstract - #2317
Merged
Merged
Conversation
BREAKING CHANGE: Custom `RequestQueueClient` subclasses must implement `is_finished`; the `is_empty` fallback is removed.
vdusek
added
the
t-tooling
vdusek
marked this pull request as ready for review
October 13, 2026 12:03
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #2317 +/- ##
=====================================
Coverage ? 94.12%
=====================================
Files ? 183
Lines ? 13561
Branches ? 0
=====================================
Hits ? 12764
Misses ? 797
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
added a commit
that referenced
this pull request
Oct 16, 2026
Makes `RequestQueueClient.is_finished` abstract. The default fell back to `is_empty`, which ignores requests still in progress, so a custom client could report its queue as finished too early. All built-in clients and the Apify SDK clients already implement the method. The v2 upgrade guide tells custom client authors to implement it. Closes: #1985 *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
RequestQueueClient.is_finishedabstract. The default fell back tois_empty, which ignores requests still in progress, so a custom client could report its queue as finished too early. All built-in clients and the Apify SDK clients already implement the method. The v2 upgrade guide tells custom client authors to implement it.Closes: #1985
✍️ Drafted by Claude Code