Skip to content

refactor: use asyncio.TaskGroup in the error snapshotter #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 7 commits into from
Oct 14, 2026
Merged

refactor: use asyncio.TaskGroup in the error snapshotter #2321

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10e9ab1
refactor: use task groups for concurrent fan-out
vdusek Oct 13, 2026
4d1a67c
refactor: harden task_group error selection
vdusek Oct 13, 2026
9beea16
refactor: keep the page coroutines list in new_page_with_each_plugin
vdusek Oct 13, 2026
7366cfa
refactor: keep the list-then-await shape when switching to run_all
vdusek Oct 13, 2026
1951b64
refactor: drop task_group/run_all helpers and use asyncio.TaskGroup o…
vdusek Oct 14, 2026
2c283c6
refactor!: use asyncio.TaskGroup for robots.txt skips, BrowserPool an…
vdusek Oct 14, 2026
27523d0
refactor: keep gather for robots.txt skips, BrowserPool and infinite_…
vdusek Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/crawlee/statistics/_error_snapshotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,13 @@ async def capture_snapshot(
if snapshot := await context.get_snapshot():
kvs = await KeyValueStore.open(name=self._kvs_name)
snapshot_base_name = self._get_snapshot_base_name(error_message, file_and_line)
snapshot_save_tasks = list[asyncio.Task]()

if snapshot.html:
snapshot_save_tasks.append(
asyncio.create_task(self._save_html(kvs, snapshot.html, base_name=snapshot_base_name))
)
async with asyncio.TaskGroup() as tg:
if snapshot.html:
tg.create_task(self._save_html(kvs, snapshot.html, base_name=snapshot_base_name))

if snapshot.screenshot:
snapshot_save_tasks.append(
asyncio.create_task(self._save_screenshot(kvs, snapshot.screenshot, base_name=snapshot_base_name))
)

await asyncio.gather(*snapshot_save_tasks)
if snapshot.screenshot:
tg.create_task(self._save_screenshot(kvs, snapshot.screenshot, base_name=snapshot_base_name))

async def _save_html(self, kvs: KeyValueStore, html: str, base_name: str) -> None:
file_name = f'{base_name}.html'
Expand Down
Loading