Repository navigation
docs: fix links and the sidebar entry broken by the docs restructure - #2408
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #2408 +/- ##
=====================================
Coverage ? 94.60%
=====================================
Files ? 194
Lines ? 14151
Branches ? 0
=====================================
Hits ? 13388
Misses ? 763
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ropped 3.10" This reverts commit aa6b641.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing
v2ontomastercombinedv2's changes withmaster's docs restructure (#2197). Four references ended up pointing at pages or ids that no longer exist, and the Docusaurus build fails on them:website/sidebars.jslistsconcepts/storage-clients, which refactor(storages)!: rename storage clients to storage backends #2362 renamed tostorage-backends. The build stops on the invalid sidebar id.enum/Event, butEventis aStrEnumin v2 (chore!: drop Python 3.10 support #2295), so its API page isclass/Event.../concepts/storage-clients.../guides/proxy-management,../guides/scaling-crawlersand../guides/request-loaders, which now live under../concepts/. The anchors they point at exist on the concept pages.Snapshotterdrives autoscaling and link its API page. In v2,Snapshotteris private and has no API page. The CPU and memory load signals listen to the system info events, and the crawler builds its defaultConcurrencySystemfrom its configuration. The pages now say that and link those classes. The site build doesn't check API links, so it didn't flag these.PR CI doesn't build the site, so only the docs release would catch these. With this change,
pnpm buildpasses locally. The remaining broken-anchor warnings come from the frozen 0.6 API reference and from aRequest#user_datalink thatmasterhas too.This should be merged before the logging stack (#2402–#2404). The CI part of the rebase fallout is in #2409.
✍️ Drafted by Claude Code