Replace typescript-private methods with native-private

[janbuchar]

• refactor!: use native private class fields and remove underscore prefixes #3980 and Redesign or retire the remaining test seams that reach into private members #3983 covered class properties. Methods were never in scope, but crawlee/prefer-private-fields flags them too
• on master, there's 200+ private methods
• until we resolve this, we cannot make prefer-private-fields an error instead of warning

Spy seams

A test asserts a private method was called, so # breaks it outright rather than needing a rewrite.

• BrowserPool.executeHooks (8 sites), launchBrowser (2), overridePageClose, closeRetiredBrowserWithNoPages, closeInactiveRetiredBrowsers
• ConcurrencySystem.autoscale (9) — tests step the autoscaling loop by hand. Also does this.autoscale = this.autoscale.bind(this) in the constructor, which is illegal for a # method; it would have to become a private field holding an arrow function.
• SessionPool.ensureInitialized (3), createSession

Internals invoked directly

No public path to the behaviour under test.

• BasicCrawler.resolveRequestHandlerTimeoutMillis — currently the only handle on the 2^31-1 clamp, see refactor(core): retire TS-private test seams and convert to native private fields #4043

• BasicCrawler.isTaskReadyFunction, runInStorageTransaction, isAllowedBasedOnRobotsTxtFile (2)

• HttpCrawler.encodeResponse (2)

• ImpitHttpClient.getClient (4) — asserts per-proxy client caching

• BrowserLauncher.getTypicalChromeExecutablePath (3)

• StagehandController.waitForStagehandToRegisterPage (2)

• Dataset.bufferedJournalEntries / KeyValueStore.bufferedJournalEntries

• Related: Unify naming conventions for protected/private class members #3108, refactor!: use native private class fields and remove underscore prefixes #3980, Redesign or retire the remaining test seams that reach into private members #3983

[B4nan]

on master, there's 200+ private methods

Honestly, I would rather keep this and adjust the lint rule so it ignores methods. We can get there over time, I wouldn't block v4 release on this.

[janbuchar]

on master, there's 200+ private methods

Honestly, I would rather keep this and adjust the lint rule so it ignores methods. We can get there over time, I wouldn't block v4 release on this.

I trust your judgment on that, but still, isn't this a fairly mechanical task that should be easy for an LLM?

[B4nan]

For the conversion part - yes, but dealing with the private method usage in tests might be a bit harder. Feel free to burn some tokens on this to see.

[B4nan]

So I did the native private props for SDK too (apify/apify-sdk-js#699), and asked claude how hard would it be to do it for methods as well (both in crawlee and sdk). Guess what, he agrees with what I said above:

Short answer: much harder than the properties pass, for much less benefit — I'd advise against it.