Skip to content

fix: vulnerabilities - #59

Merged
protoss70 merged 3 commits into
masterfrom
fix/vulnerability-fixes
Sep 17, 2026
Merged

protoss70 merged 3 commits into
masterfrom
fix/vulnerability-fixes

Conversation

@protoss70

Copy link
Copy Markdown
Contributor

fixes vulnerabilities, there are still some remaining coming from n8n packages. I cannot override them because n8n linting doesn't allow it

@drobnikj maybe we should consider removing n8n-nodes-apify from the vulnerabilities repos.

@protoss70
protoss70 requested a review from drobnikj September 15, 2026 16:23
@protoss70 protoss70 self-assigned this Sep 15, 2026
@protoss70 protoss70 added adhoc Ad-hoc unplanned task added during the sprint. t-integrations Issues with this label are in the ownership of the integrations team. labels Sep 15, 2026
@protoss70

Copy link
Copy Markdown
Contributor Author

@apify-factory please fix the lint issues.

Here is some info from n8n docs AI

Fixing Your Two Lint Errors
Error 1: @n8n/community-nodes/require-continue-on-fail — Rule Not Found
This error means the ESLint rule definition isn't being found, which typically indicates a configuration or dependency issue rather than a code problem.

The knowledge sources do not explicitly describe this specific rule or its fix in detail. However, based on the linter documentation, the recommended steps are:

Ensure your dependencies are up to date. Run:
npm install
Do not edit eslint.config.mjs — this file is managed by @n8n/node-cli and should not be modified manually. [[Node linter](https://docs.n8n.io/connect/create-nodes/test-your-node/node-linter)]
Try auto-fixing with:
npm run lint:fix
This will automatically fix violations of rules marked as fixable. [[Node linter](https://docs.n8n.io/connect/create-nodes/test-your-node/node-linter)]
If the rule is still "not found" after reinstalling, it likely means your @n8n/eslint-plugin-community-nodes package is outdated and doesn't include this rule yet. Update your @n8n/node-cli to the latest version.

Error 2: @n8n/community-nodes/node-usable-as-tool — Trigger Node Has usableAsTool: true
This one is clear: trigger nodes must not have usableAsTool: true. The linter message explains it directly — trigger nodes cannot be invoked as AI tools.

Fix: Open ApifyTrigger.node.ts and remove the usableAsTool: true property at line 154.

// Remove this line from your trigger node:
usableAsTool: true,
This is consistent with n8n's design — usableAsTool is only valid for regular (non-trigger) nodes. Community forum reports confirm that even adding usableAsTool: true to custom nodes can cause errors like Unrecognized node type, and it's especially inappropriate for trigger nodes. [[Custom Node as AI tool](https://community.n8n.io/t/70176)]

General Advice
Run npm run lint to verify all issues after making changes.
If you believe a linting rule is incorrectly flagging your code, you can [report it in the n8n repository](https://github.com/n8n-io/n8n/issues) or add a targeted ESLint disable comment with a reason (only when justified). [[Node linter](https://docs.n8n.io/connect/create-nodes/test-your-node/node-linter)]

@github-actions

Copy link
Copy Markdown
Contributor

AGENTS.md updated

  • dropped the claim that Apify.node.ts#execute keeps a require-continue-on-fail eslint-disable — this PR removed it
  • "Both nodes set usableAsTool: true" is now wrong; ApifyTrigger.node.ts no longer does

Committed to this PR. Review it like any other commit. Feel free to edit it.

@protoss70
protoss70 merged commit 33cb5f4 into master Sep 17, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-integrations Issues with this label are in the ownership of the integrations team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants