Guard against null audit-log response in AuditOrganizationsClient

Octokit.Tests/Clients/AuditOrganizationsClientTests.cs

@@ -0,0 +1,61 @@
+using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using NSubstitute;
+using Xunit;
+
+namespace Octokit.Tests.Clients
+{
+    public class AuditOrganizationsClientTests
+    {
+        public class TheCtor
+        {
+            [Fact]
+            public void EnsuresNonNullArguments()
+            {
+                Assert.Throws<ArgumentNullException>(() => new AuditOrganizationsClient(null));
+            }
+        }
+
+        public class TheAuditLogQueryMethods
+        {
+            private static AuditOrganizationsClient CreateClientReturningNullResponse()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                connection.Get<List<AuditLogEvent>>(Arg.Any<Uri>(), Arg.Any<IDictionary<string, string>>())
+                    .Returns(Task.FromResult<List<AuditLogEvent>>(null));
+                return new AuditOrganizationsClient(connection);
+            }
+
+            [Fact]
+            public async Task GetRepositoryVisibilityChangeLastEventReturnsNullWhenResponseIsNull()
+            {
+                var client = CreateClientReturningNullResponse();
+
+                var result = await client.GetRepositoryVisibilityChangeLastEvent("org", new AuditLogPhraseOptions { Repository = "repo" });
+
+                Assert.Null(result);
+            }
+
+            [Fact]
+            public async Task GetRepositoryCreatedLastEventReturnsNullWhenResponseIsNull()
+            {
+                var client = CreateClientReturningNullResponse();
+
+                var result = await client.GetRepositoryCreatedLastEvent("org", new AuditLogPhraseOptions { Repository = "repo" });
+
+                Assert.Null(result);
+            }
+
+            [Fact]
+            public async Task GetUserLastActivityForRepositoryDateReturnsNullWhenResponseIsNull()
+            {
+                var client = CreateClientReturningNullResponse();
+
+                var result = await client.GetUserLastActivityForRepositoryDate("org", new AuditLogPhraseOptions { Repository = "repo", User = "user" });
+
+                Assert.Null(result);
+            }
+        }
+    }
+}

Octokit/Clients/AuditOrganizationsClient.cs

@@ -56,7 +56,7 @@ public AuditOrganizationsClient(IApiConnection apiConnection) : base(apiConnecti
             var phrase = auditLogPhraseOptions.BuildPhrase(organization, "repo.access");
             var auditLogs = await ApiConnection.Get<List<AuditLogEvent>>(ApiUrls.AuditLog(organization, phrase), parameters);
 
-            if (!auditLogs.Any())
+            if (auditLogs is null || !auditLogs.Any())
             {
                 return null;
             }
@@ -97,7 +97,7 @@ public AuditOrganizationsClient(IApiConnection apiConnection) : base(apiConnecti
             var phrase = auditLogPhraseOptions.BuildPhrase(organization, "repo.create");
             var auditLogs = await ApiConnection.Get<List<AuditLogEvent>>(ApiUrls.AuditLog(organization, phrase), parameters);
 
-            if (!auditLogs.Any())
+            if (auditLogs is null || !auditLogs.Any())
             {
                 return null;
             }
@@ -120,7 +120,7 @@ public AuditOrganizationsClient(IApiConnection apiConnection) : base(apiConnecti
             var phrase = auditLogPhraseOptions?.BuildPhrase(organization);
             var auditLogs = await ApiConnection.Get<List<AuditLogEvent>>(ApiUrls.AuditLog(organization, phrase), parameters);
 
-            if (!auditLogs.Any())
+            if (auditLogs is null || !auditLogs.Any())
             {
                 return null;
             }

Octokit/Octokit.csproj

@@ -4,7 +4,7 @@
     <Description>An async-based GitHub API client library for .NET and .NET Core</Description>
     <AssemblyTitle>Octokit</AssemblyTitle>
     <Authors>GitHub</Authors>
-    <Version>1.0.27</Version>
+    <Version>1.0.28</Version>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <AssemblyName>Octokit</AssemblyName>
     <PackageId>Apiiro.Octokit</PackageId>