feat(incremental-planner): add commit logic and BulbSearchSpace impl - #10106
Open
tninesling wants to merge 3 commits into
Open
feat(incremental-planner): add commit logic and BulbSearchSpace impl#10106tninesling wants to merge 3 commits into
tninesling wants to merge 3 commits into
Conversation
Contributor
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 1 new, 21 changed, 0 removedBuild ID: 9d800748103fd9cd447d3a6e URL: https://www.apollographql.com/docs/deploy-preview/9d800748103fd9cd447d3a6e ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
Contributor
Merge Protections🔴 1 of 1 protections blocking · waiting on ⛓️ dependency
🔴 ⛓️ Depends-On RequirementsWaiting for
This rule is failing.Requirement based on the presence of
|
This was referenced Aug 28, 2026
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
August 28, 2026 17:11
b043aba to
ec75195
Compare
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
August 28, 2026 17:36
ec75195 to
788875a
Compare
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
2 times, most recently
from
August 28, 2026 18:33
4a82420 to
2d06f42
Compare
tninesling
marked this pull request as ready for review
August 28, 2026 18:46
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
August 28, 2026 19:09
2d06f42 to
3549bcf
Compare
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
August 31, 2026 22:51
3549bcf to
2d06f42
Compare
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
August 31, 2026 23:40
2d06f42 to
2dd86b1
Compare
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
August 31, 2026 23:46
2dd86b1 to
2d06f42
Compare
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
September 1, 2026 01:35
485fc5b to
4b5117d
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dead code with no callers across any stack. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tninesling
force-pushed
the
tninesling/inc-port-7-commit-logic
branch
from
September 1, 2026 01:40
4b5117d to
73b5390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
commit.rs, which applies a routing choice to the plan state: creating or reusing fetch groups, wiring dependency edges, recording entity inputs, and dispatching sub-selections back onto the pending stack.This is also where
FieldRoutingSearchSpaceimplements theBulbSearchSpacetrait, connecting the generic BULB engine to the federation-specific routing:options(): delegates to routing enumeration (PR feat(incremental-planner): add routing enumeration #10105) based on selection type (field, fragment, federated root)commit_choice(): applies the chosen option via commit logic, advancing the search statefast_forward(): greedily commits single-option selections without branching, skipping the BULB machinery for the common caseThe commit logic handles direct edges, key hops (single and chained), root type hops, and @requires condition routing.
CONDITION_DEPTH_LIMITbounds recursive @requires resolution to prevent infinite loops from circular directives.Test plan