Add usage gauges for Datadog exporter sub-features (ROUTER-1962) - #10125
Open
SharkBaitDLS wants to merge 1 commit into
Open
Add usage gauges for Datadog exporter sub-features (ROUTER-1962)#10125SharkBaitDLS wants to merge 1 commit into
SharkBaitDLS wants to merge 1 commit into
Conversation
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: ed475f08b2c59324c596d2ba ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
The native Datadog trace exporter's deprecation in favor of OTLP has been documented for some time. Today only exporter on/off is measurable via the opt.tracing.datadog attribute; these new attributes on apollo.router.config.telemetry record which Datadog-specific options are explicitly configured (span mapping, fixed span names, resource mapping, span metrics, per-exporter sampler, agent sampling, Datadog propagation), so deprecation planning and migration guidance can be informed by usage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SharkBaitDLS
force-pushed
the
sharkbaitdls/router-1962-datadog-usage-gauges-2x
branch
from
September 1, 2026 00:11
2505daf to
9cf6f15
Compare
SharkBaitDLS
marked this pull request as ready for review
September 1, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native Datadog trace exporter's documented deprecation in favor of OTLP needs usage data to plan against, but today only exporter on/off is measurable (the
opt.tracing.datadogattribute). This adds seven attributes to the existingapollo.router.config.telemetrygauge recording which Datadog-specific options are explicitly configured:opt.tracing.datadog.enable_span_mappingtelemetry.exporters.tracing.datadog.enable_span_mapping: trueopt.tracing.datadog.fixed_span_names...datadog.fixed_span_names: trueopt.tracing.datadog.resource_mapping...datadog.resource_mapping(set)opt.tracing.datadog.span_metrics...datadog.span_metrics(set)opt.tracing.datadog.sampler...datadog.sampler(value)opt.tracing.common.preview_datadog_agent_sampling...tracing.common.preview_datadog_agent_sampling: trueopt.tracing.propagation.datadog...tracing.propagation.datadog: trueSemantics follow the existing pattern: attributes reflect explicit operator configuration (
validated_yaml), not materialized defaults. No new instrument or mechanism — this extends the existingpopulate_config_instrument!block.Targeting
devso the gauges reach the 2.x line, where most Datadog exporter usage lives; it reachesdev-v3.xthrough the regular forward-port.ROUTER-1962
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
apollo.router.config.*gauges are internal usage instrumentation and are not part of the documented user-facing metrics surface; no doc change needed.configuration::metrics::test::test_metrics), consistent with all other attributes on this instrument.Notes
🤖 Generated with Claude Code
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩