-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Playwright test framework - API & UI automation #1678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
1ef3f29
871c2ed
b622e8f
5132e34
99cc2b6
a1907e0
e7e9639
893d61b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "cookies": [], | ||
| "origins": [ | ||
| { | ||
| "origin": "https://sherlockprivacy.qa.do.appknox.io", | ||
| "localStorage": [ | ||
| { | ||
| "name": "ember_simple_auth-session", | ||
| "value": "{\"authenticated\":{\"authenticator\":\"authenticator:irene\",\"token\":\"653b5bbdfffd105d36fce72207778e3b060f379bc87316ca18334e62988fa11f\",\"user_id\":1,\"b64token\":\"MTo2NTNiNWJiZGZmZmQxMDVkMzZmY2U3MjIwNzc3OGUzYjA2MGYzNzliYzg3MzE2Y2ExODMzNGU2Mjk4OGZhMTFm\"}}" | ||
|
Comment on lines
+8
to
+9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove committed session secrets from repository history. Line 9 includes live auth material ( 🔧 Suggested fix {
"cookies": [],
- "origins": [
- {
- "origin": "https://sherlockprivacy.qa.do.appknox.io",
- "localStorage": [
- {
- "name": "ember_simple_auth-session",
- "value": "{\"authenticated\":{\"authenticator\":\"authenticator:irene\",\"token\":\"...\",\"user_id\":1,\"b64token\":\"...\"}}"
- }
- ]
- }
- ]
+ "origins": []
}Also ensure auth state files are generated at runtime in global setup and ignored by git (e.g., add auth-state paths to 🤖 Prompt for AI Agents |
||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,3 +58,5 @@ export default Factory.extend({ | |
|
|
||
| remediation: () => faker.lorem.paragraphs(), | ||
| }); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoded origin in persisted auth state.
Line 5 hardcodes a QA host, which undermines the multi-environment (
qa/prod) goal and makes state reuse fragile across environments.🔧 Suggested direction
Generate storage state per environment during global setup instead of committing environment-specific state.
🤖 Prompt for AI Agents