Repository navigation
fix(deps): update jvm sdk template dependencies - #1935
renovate-appwrite[bot] wants to merge 1 commit into
Conversation
|
a52a94c to
8df1353
Compare
| implementation("com.hivemq:hivemq-mqtt-client:1.4.0") | ||
| implementation("androidx.core:core-ktx:1.19.1") |
There was a problem hiding this comment.
This test now compiles the generated push module with HiveMQ 1.4.0 and AndroidX Core 1.19.1, but the generated plugin still declares 1.3.6 and 1.13.1. A passing test therefore cannot rule out failures specific to the versions consumers receive. Keep the test dependencies aligned with the generated plugin.
Knowledge Base Used: End-to-end SDK suites
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/e2e/languages/react-native/android-test/build.gradle.kts
Line: 26-27
Comment:
**Native test dependency drift**
This test now compiles the generated push module with HiveMQ 1.4.0 and AndroidX Core 1.19.1, but the generated plugin still declares 1.3.6 and 1.13.1. A passing test therefore cannot rule out failures specific to the versions consumers receive. Keep the test dependencies aligned with the generated plugin.
**Knowledge Base Used:** [End-to-end SDK suites](https://app.greptile.com/appwrite/-/custom-context/knowledge-base/appwrite/sdk-generator/-/docs/end-to-end-sdk-suites.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
8df1353 to
ea2391f
Compare
🟡 Tier B · Needs changes before merging
This update bumps the Gradle wrappers used by the Android and Kotlin templates to 9.8.1. It also updates Android Gradle Plugin and Android dependency versions in the Flutter and React Native Android e2e harnesses.
Note Not approving while a bug finding is open: Apply the dependency updates to the generated SDK templates Fix with agent prompt### Issue 1
tests/e2e/languages/react-native/android-test/build.gradle.kts:26-28
**Apply the dependency updates to the generated SDK templates**
These bumps currently affect only the React Native e2e harness: generated packages still use HiveMQ 1.3.6 and AndroidX Core 1.13.1 in `templates/react-native/android/build.gradle.twig` and `templates/flutter/android/build.gradle.twig`, and `templates/android/build.gradle.kts.twig` still pins AGP 9.4.0. Consumers therefore don't receive the announced dependency updates, while the harness tests a different dependency set from the generated SDKs.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 4
⏳ Still open from earlier reviews · 1
Reviewed |
ea2391f to
8384c7f
Compare
| implementation("com.hivemq:hivemq-mqtt-client:1.4.1") | ||
| implementation("androidx.core:core-ktx:1.19.1") | ||
| implementation("com.facebook.react:react-android:0.87.1") |
There was a problem hiding this comment.
Apply the dependency updates to the generated SDK templates
These bumps currently affect only the React Native e2e harness: generated packages still use HiveMQ 1.3.6 and AndroidX Core 1.13.1 in templates/react-native/android/build.gradle.twig and templates/flutter/android/build.gradle.twig, and templates/android/build.gradle.kts.twig still pins AGP 9.4.0. Consumers therefore don't receive the announced dependency updates, while the harness tests a different dependency set from the generated SDKs.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/e2e/languages/react-native/android-test/build.gradle.kts
Line: 26-28
Comment:
**Apply the dependency updates to the generated SDK templates**
These bumps currently affect only the React Native e2e harness: generated packages still use HiveMQ 1.3.6 and AndroidX Core 1.13.1 in `templates/react-native/android/build.gradle.twig` and `templates/flutter/android/build.gradle.twig`, and `templates/android/build.gradle.kts.twig` still pins AGP 9.4.0. Consumers therefore don't receive the announced dependency updates, while the harness tests a different dependency set from the generated SDKs.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
8384c7f to
1952d1d
Compare
This PR contains the following updates:
9.7.1→9.8.10.76.9→0.88.01.13.1→1.19.11.3.6→1.4.19.4.0→9.4.1Release Notes
gradle/gradle (gradle)
v9.8.1: 9.8.1Compare Source
This is a patch release for Gradle 9.8.0. We recommend using 9.8.1 instead of 9.8.0.
This release addresses three high rated vulnerabilities:
The following issues were resolved:
Read the Release Notes
We would like to thank the following community members for their contributions to this release of Gradle:
Aman Gautam,
Björn Kautler,
Eng Zer Jun,
Hashim Khan,
Julian Krannich,
KBS,
Labh R Jethe,
Mark Dodgson,
Maxim,
monkey,
nataphon-ktsystems,
Paul King,
Qiu Tian,
rg_sandesh,
Roberto Perez Alcolea,
Sean,
Zongle Wang.
Upgrade instructions
Switch your build to use Gradle 9.8.1 by updating your wrapper:
See the Gradle 9.x upgrade guide to learn about deprecations, breaking changes and other considerations when upgrading.
For Java, Groovy, Kotlin and Android compatibility, see the full compatibility notes.
Reporting problems
If you find a problem with this release, please file a bug on GitHub Issues adhering to our issue guidelines.
If you're not sure you're encountering a bug, please use the forum.
We hope you will build happiness with Gradle, and we look forward to your feedback via Twitter or on GitHub.
v9.8.0: 9.8.0Compare Source
The Gradle team is excited to announce Gradle 9.8.0.
Here are the highlights of this release:
Read the Release Notes
We would like to thank the following community members for their contributions to this release of Gradle:
Aman Gautam,
Björn Kautler,
Eng Zer Jun,
Hashim Khan,
Julian Krannich,
KBS,
Labh R Jethe,
Mark Dodgson,
Maxim,
monkey,
nataphon-ktsystems,
Paul King,
Qiu Tian,
rg_sandesh,
Roberto Perez Alcolea,
Sean,
Zongle Wang.
Upgrade instructions
Switch your build to use Gradle 9.8.0 by updating your wrapper:
See the Gradle 9.x upgrade guide to learn about deprecations, breaking changes and other considerations when upgrading.
For Java, Groovy, Kotlin and Android compatibility, see the full compatibility notes.
Reporting problems
If you find a problem with this release, please file a bug on GitHub Issues adhering to our issue guidelines.
If you're not sure you're encountering a bug, please use the forum.
We hope you will build happiness with Gradle, and we look forward to your feedback via Twitter or on GitHub.
facebook/react-native (com.facebook.react:react-android)
v0.88.0: 0.88.0Added
<React/FeatureFlags.h>umbrella header as the public entry point forreact/featureflags(f970054a8a by @j-piasecki)<React/RendererBridging.h>umbrella header as the public entry point forreact/renderer/bridging(5b680c5f9f by @j-piasecki)<React/Timing.h>umbrella header as the public entry point forreact/timing(70f172d29f by @j-piasecki)addEventListener,removeEventListener,dispatchEvent) on native view refs in canary (8480b86820 by @rubennorte)enableImageTransparentTintColorfeature flag (c5bd054983 by @coado)'react-native/Libraries/Core/InitializeCore'. Use'react-native/setup-env'instead. (554baba159 by @huntie)Page.captureScreenshotis added to theEXPERIMENTALchannel (4be68ef785 by @huntie)CANARYchannel (713ae6b1b9 by @huntie)Page.captureScreenshotcommand (00efc0a440 by @huntie)fontVariationSettings(376b99ff14 by @evankatz14)isInstalled()andclearAllLogs()to theLogBoxTypeScript declarations (a69badd468 by @Abbondanzo)requestIdleCallbackandcancelIdleCallback(c086431a4b by @Critteros)Android specific
enableMountingCoordinatorPullModelAndroidfeature flag (ece0efe837 by @coado)User-Agentheader for network requests, matching iOS (04e50d540d by Calvin Liu)PullTransactionMountItem,FabricUIManager.onTransactionAvailable) for the pull model (6515647d94 by @coado)enableMountingCoordinatorPullModelAndroid(9da1a01153 by @coado)fontVariationSettingssupport for<Text>(19f7d144b9 by @evankatz14)fontVariationSettingssupport forTextInput(a688608090 by @evankatz14)ArrayBuffer, the Java representation of a JSArrayBufferfor TurboModules, with an explicit byte-ownership contract (5bb9639594 by Kamil Paradowski)ArrayBufferbytes are scoped to the synchronous call that received them.ArrayBuffer.bytesandArrayBuffer.sizethrowIllegalStateExceptionafterwards, and aByteBufferalready obtained frombytesis unchecked and reads freed memory, so copy withArrayBuffer.arrayBufferWithCopiedBytesto keep them (d84c13d511 by @christophpurrer)iOS specific
fontVariationSettingssupport on iOS (8415753e21 by @evankatz14)React-cxxstableapidependency to third-party New Architecture pods so they can resolve React Native's C++ API guard headers (d3daf111e0 by @coado)RCT_REMOVE_LEGACY_MODULE_INTEROPandRCT_REMOVE_LEGACY_COMPONENT_INTEROPfrom CocoaPods and SwiftPM. Both default to off and will become the default in a future release (b933d18177 by @christophpurrer)shadow*styles without providing a solid background color (eb4d3892ab by @hannojg)Changed
Platform.OSandPlatform.select(...)inlining inreact-native/babel-presetnow requires theinlinePlatformoption in addition toplatform(f63b2a1cb5 by @robhogan)Platform.OSandPlatform.select(...)for React NativePlatformimports during the Babel preset, covering some cases that were previously left un-inlined. (40c06121a1 by @robhogan)2603180.0.3 (79024f7c59 by @fabriziocucci)2603180.0.4 (993be7d6c6 by @fabriziocucci)2603180.0.1 (b113cf5864 by @fabriziocucci)ActivityIndicatorView,ModalHostView,PullToRefreshView,SafeAreaView,Switch) no longer report legacyRCT-prefixed names in their view configs (904812016f by @christophpurrer)RuntimeSchedulernow clears pending tasks and rendering updates when a task throws (14184ec643 by @javache)CallInvokerwork is now buffered alongside callable module calls, so it no longer runs before the JS bundle has finished evaluating (3ca6ea3eca by @javache)experimental_prefix frombackgroundSize,backgroundPositionandbackgroundRepeat(7844386bbd by @intergalacticspacehighway)UIManager::startSurfaceandUIManager::setSurfacePropsnow takemoduleNameandpropsby value (85a81818c6 by @javache)Android specific
tintColoranstd::optionalto support colortransparent(0) with props 2.0 (f535c97904 by @hannojg)iOS specific
RCTBundleURLProviderAllowPackagerServerAccessunconditionally (no-op when packager support is compiled out) (54656471a5 by @ramonclaudio)RCTGetModuleClasses/RCTRegisterModuleand skip static module registration when bothRCT_REMOVE_LEGACY_MODULE_INTEROPandRCT_REMOVE_LEGACY_COMPONENT_INTEROPare defined (5d62ca4296 by @christophpurrer)Deprecated
Android specific
InputAccessoryView(102fde7b6b by @zoontek)Fixed
addListenerfires again for natively drivenAnimatedvalues derived withadd/subtract/multiply/divide/modulo/diffClamp/interpolate(ce621bbd5b by @dennytosp)ReactRevisionMergesource to the AnimationBackendCommitHook (ca53751780 by Bartlomiej Bloniarz)NativeModule.ios.ts) resolve correctly (f46ace878a by @Gregoirevda)DeviceInfoconstants on each read (9d10e39d32 by @artus9033)loadstart, throwInvalidStateErroron overlapping reads, and exposeFileReader.erroras aDOMException. (544141efab by @Abbondanzo)FileReaderin the correct state after aborting a read. (e92816c5a5 by @fallintoplace)at <position>being ignored (and corrupting the size) when it follows an explicit size (66f27eb93e by @Titozzz)interface, fixing compatibility with certain DefinitelyTyped packages (593ae0258d by @huntie)DOMHighResTimeStampback to nanoseconds, soHighResTimeStampandHighResDurationround trips are exact (c467843ed0 by @GijsWeterings)transformOriginstring parsing for decimal percentage and pixel values. (0a60ec9dea by @MayankSharma-2812)transformOriginstrings. (4501979c1a by @fallintoplace)RCTArrayBuffercodegen change, restoringNSMutableData *for ObjC TurboModule methods that take or return anArrayBuffer. 0.88 is a non-breaking release, and the change stopped modules that adopted ObjCArrayBuffersupport in 0.87 from compiling (639cdedb50, 19a3184981 by @fabriziocucci)ArrayBufferas a TurboModuleEventEmitterpayload. C++ TurboModules could declareEventEmitter<ArrayBuffer>in 0.87 and it generated working code, so rejecting it at codegen time broke those builds (070af03ab3 by @fabriziocucci)AssetRegistryAPI (b8ec87e457 by @byCedric)codegenNativeComponentdue to unreachableNativeComponentType<T>(391723e869 by @artus9033).jsfallback for legacy deep imports of untyped modules, soreact-native/Libraries/*specifiers resolve again under thereact-native-legacy-deep-importscondition (579212e15c by @fabriziocucci)react-native/virtualized-listsimporting an unexported React Native subpath (a506ed66cc by @giaBaoJS)Android specific
accessibilityRole="tabbar"is used on Android (a4733b1ca1 by @aravi365)accessibilityState.disabledresets fromtrue, which leftPressablepartly untappable (357b6998c4 by @bigcupcoffee)jserrorhandlerheaders in thereactnativeprefab so external consumers of cxxreact/ErrorUtils.h can build. (f2a6db9fce by @alanjhughes)/tmpfor the build-from-source container project dirs, fixing Gradle configuration on Windows (908872a68e by @kraenhansen)String?overloads ofReactImageManager#setDefaultSourceandReactImageManager#setLoadingIndicatorSource(3a95e0e93c by @hannojg)Image.getSize()andImage.getSizeWithHeaders()rejectingdata:URIs (8cfde6d083 by Cole Huntley)SurfaceMountingManager(d6a5f159c6 by @pawicao)outlineColoris provided as a numeric color value (53b933feca by HURRAEY)Doubleprop defaults being rounded to float precision in generatedViewManagerdelegates (2c4278d83b by @dennytosp)RuntimeException: Unrecognized type: class com.facebook.yoga.YogaValuewhen aViewManagerimplements aDimensionValueprop withReactProp(091ac613ce by @dennytosp)RuntimeException: Unrecognized type: class java.lang.Floatwhen aViewManagerimplements a nullable float prop (WithDefault<Float, null>) withReactProp(8d23b14da6 by @dennytosp)iOS specific
codegenConfig.jsSrcsDircontained noNative*/*NativeComponentspec files. (0b0eb8d012 by @Levin-nik)node_modulesor follows symlinks when discovering components (39751d864d by @gabrieldonadel)DeviceInfoconstants after interface dimension changes (b743a8a35b by @artus9033)always_out_of_dateon hermes-engine'sReplace Hermesscript phase (d89c432659 by @ramonclaudio)textAlignis not set, matching Android (1b92b02f99 by @zoontek)host:didInitializeRuntime:callback to user delegate inRCTReactNativeFactory(98dc7d6423 by @zhongwuzw)RCTViewComponentViewchild-index mismatch instead of raisingNSRangeExceptionwhile formatting the assert message (1291d7ce8e by @dongdongbh)ReactInstance::registerSegmentwhen an on-demand JS segment file is missing from the cache at lazy-load time (fff4994af8 by generatedunixname1608173377072046)outlineStyle: 'dotted'and'dashed'on views without border radii (9f31d5ae9f by @neutronm)IPHONEOS_DEPLOYMENT_TARGETinstead of hardcoding iOS 15, so dependencies with a higher minimum (e.g. Expo, 16.4) can be autolinked (92564f33fd by @chrfalch)Package.swift(97cc934dc7 by @chrfalch)paperComponentName: 'RCTSwitch'to fixtesting-library/react-nativequeries (38fd9d57df by @christophpurrer)UIFontWeightUltraLightinRCTGetFontWeight(3b5d0a6526 by @vonovak)keyboardType/returnKeyTypechange while the input is focused (new architecture parity with the legacy architecture) (0f1bdddfb3 by @NoahDorfman00)nullTurboModule argument to Objective-C asnilinstead ofNSNullwhenenableModuleArgumentNSNullConversionIOSis enabled (ea291d7422 by @christophpurrer)Security
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate.