Repository navigation
fix(unity): compile WebGL players without MQTTnet - #2058
Merged
Merged
Conversation
MQTTnet.dll is left out of WebGL players, so Push now uses it only off WebGL and WebGL gets a Push whose subscribe fails with PlatformNotSupportedException. The managed System.Text.Json dependencies, which Client already imports on every platform, are enabled for WebGL.
🟢 Tier S · Ready to merge
The Unity templates now conditionally exclude the MQTT-backed Push implementation from WebGL players and provide a Push stub whose subscribe methods return
📂 Walkthrough · 3
Reviewed |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MQTTnet.dllis left out of WebGL players, butPushimported it on every platform, so WebGL builds failed to compile.ClientimportsSystem.Text.Jsonon every platform, but it and its four managed dependencies were also left out of WebGL, so they are now enabled there.MQTTnet.dllstays off WebGL.Test:
testUnityImportsPluginsLeftOutOfWebglOnlyOffWebglfails onmain(Push.cs imports mqttnet, andClient.cs imports system.text.jsonwith only the guard). The generatedPush.cscompiles withUNITY_WEBGLdefined. GenerationTest passes (110 tests).Closes #2060