Repository navigation
Conversation
The server now names an alias-less join after its table ID, so every SDK's alias-less join forms (column form, ON-list form, crossJoin) are first-class rather than rejected. The join docblocks say so, and each SDK's query tests pin that those forms send no alias and leave the default to the server. stddev and variance map to STDDEV_POP and VAR_POP on every engine, so their docblocks now say population instead of leaving it ambiguous. The deno templates are left alone: deno is no longer a generator target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🔵 Tier A · Mergeable after minor fixes
This PR updates the generated query documentation to describe alias-less joins and clarify that
Fix with agent prompt### Issue 1
templates/web/src/query.ts.twig:827
**Qualify the default for IDs that are not valid aliases**
One caveat is missing here: the server applies this default only when `table` is valid as an alias; otherwise it returns 400. This reads as an unconditional default for every collection ID, so please qualify the limitation in this and the mirrored SDK docs.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 13
Reviewed |
|
|
||
| /** | ||
| * Inner join. `table` is the joined collection/table ID. | ||
| * Inner join. `table` is the joined collection/table ID; without an alias the join is named after it. |
There was a problem hiding this comment.
Qualify the default for IDs that are not valid aliases
One caveat is missing here: the server applies this default only when table is valid as an alias; otherwise it returns 400. This reads as an unconditional default for every collection ID, so please qualify the limitation in this and the mirrored SDK docs.
Prompt To Fix With AI
This is a comment left during a code review.
Path: templates/web/src/query.ts.twig
Line: 827
Comment:
**Qualify the default for IDs that are not valid aliases**
One caveat is missing here: the server applies this default only when `table` is valid as an alias; otherwise it returns 400. This reads as an unconditional default for every collection ID, so please qualify the limitation in this and the mirrored SDK docs.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
What
stddevandvariance: documented as population statistics. The database library maps them toSTDDEV_POPandVAR_POPon every engine.Why
Join alias is required. The database library now defaults the alias to the joined table ID when that ID is a valid alias, and otherwise returns a 400 naming the reason. (Server work is in utopia-php/query, utopia-php/database and appwrite/appwrite.)Verification
Each SDK was generated from server-ce
mainspecs and its query tests run locally:swift test; CI only builds swift)Before/after: these tests also pass on
main, because the SDKs never had the bug. The fail-before proof is at the server layer: the database library's unit and e2e tests, plus the appwrite API E2E. The new SDK tests pin the wire contract that the server default relies on.🤖 Generated with Claude Code