Repository navigation
chore(cli): build against sdk-for-go v7.13.0 - #2075
Merged
Merged
Conversation
…y and the list total options
🟢 Tier S · Ready to merge
The CLI template now pins generated modules to sdk-for-go v7.13.0. The generation example comment reflects the new pin while continuing to exclude
📂 Walkthrough · 2
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.5.x spec now has
createQueryondatabases,documentsDBandtablesDB,totalon list endpoints in activities, analytics, backups, domains, mongo, mysql and postgresql, andemailsonmessaging.createEmail/updateEmail. sdk-for-go v7.12.0 has none of them, so the CLI generated in cloud failed to compile (service.WithListEventsTotal undefined,undefined: databases.CreateQueryOption, …). sdk-for-go v7.13.0 adds them.This bumps the pin in
templates/cli/go.mod.twig.project updatePasskeyPolicystays excluded inexample.php: v7.13.0 still takes a requiredrpId.Verification
go build ./...,go vet ./...andgo test ./...pass (they fail to compile on v7.12.0).php example.php cli,gofmt -l examples/cli,go build/vet/test ./...inexamples/clipass.Related: appwrite-labs/cloud#6538