Fix: Enforce minimum TLS 1.2 for Azure Storage Account - #2207
Open
Tanmaykaturi wants to merge 20 commits into
Open
Fix: Enforce minimum TLS 1.2 for Azure Storage Account#2207Tanmaykaturi wants to merge 20 commits into
Tanmaykaturi wants to merge 20 commits into
Conversation
…e-tls-policy-1-UxldWMIb1i fix: semgrep-storage-use-secure-tls-policy
|
appuser seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…icy-8-XkhPBw3qrx fix: semgrep-aws-iam-admin-policy
…dfront-distribution-tls-v-1-GRUnyfFnVl fix: semgrep-aws-insecure-cloudfront-distribution-tls-version
…vices-logging-1-ED9FjAhb53 fix: semgrep-storage-queue-services-logging
…ancer-tls-version-9-xWIr0DQ9Hw fix: semgrep-insecure-load-balancer-tls-version
…cket-5-tU9hXysE8M fix: semgrep-s3-public-read-bucket
…ancer-tls-version-9-soB0c7ug5y fix: semgrep-insecure-load-balancer-tls-version
…ate-8-i755dXKiHh fix: semgrep-import-text-template
…late-8-YNgYcRQYmr fix: semgrep-import-text-template
…e-unencrypted-49-ybUqr7KddI fix: semgrep-aws-dynamodb-table-unencrypted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⏺ Summary
Adds an explicit min_tls_version = "TLS1_2" setting to the azurerm_storage_account.storage_accounts resource in _examples/971/modules/azure/storage-account/module.tf.
Problem
The azurerm_storage_account resource did not specify a minimum TLS version, allowing the storage account to accept connections over TLS 1.0 or TLS 1.1. Both protocols are deprecated and are known to be vulnerable to attacks such as POODLE and
BEAST. This was flagged by tfsec as storage-use-secure-tls-policy.
Solution
Explicitly set min_tls_version = "TLS1_2" on the resource to enforce TLS 1.2 as the minimum accepted protocol version.
resource "azurerm_storage_account" "storage_accounts" {
}
Impact