Skip to content

Commit 616c2f5

Browse files
committed
chore(ci): drop the dead NPM_TOKEN fallback
The secret was deleted once a release published over OIDC. Leaving the reference behind would read as a working fallback while resolving to an empty string.
1 parent 465ada6 commit 616c2f5

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,14 @@ jobs:
6666
- name: Build package
6767
run: pnpm build
6868

69-
# @semantic-release/npm prefers npm trusted publishing: it exchanges the
70-
# GitHub OIDC token above for a short-lived registry token, so no
71-
# long-lived npm credential is involved and the release carries a
72-
# provenance attestation. NODE_AUTH_TOKEN stays as the fallback — the
73-
# plugin only reaches for it when the OIDC exchange does not succeed, so
74-
# this is safe before the trusted publisher is registered on npmjs.com
75-
# and becomes dead weight once it is.
69+
# Publishing goes over npm trusted publishing: npm exchanges the GitHub
70+
# OIDC token above for a short-lived registry token, so the release
71+
# carries a provenance attestation and no long-lived npm credential
72+
# exists to expire. The NPM_TOKEN fallback was removed once a release
73+
# succeeded over OIDC — a stale token that cannot be verified is worse
74+
# than no fallback, because it reads as one.
7675
- name: Release
7776
env:
7877
GITHUB_TOKEN: ${{ github.token }}
79-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
8078
HUSKY: '0'
8179
run: pnpm semantic-release

0 commit comments

Comments
 (0)