[kediyalua]

Description

util::LazyInit::operator=(LazyInit&&) previously had no return statement. Instantiating it produces a -Wreturn-type warning, which becomes a build error under -Werror. Since the operator is unused in the codebase, it is now explicitly deleted:

LazyInit& operator=(LazyInit&&) = delete;

Following the review feedback, test/libsolutil/LazyInit.cpp is unchanged from the base branch. This PR changes only libsolutil/LazyInit.h.

No Changelog.md entry: the operator was unused and could not be compiled with -Werror.

Checklist

• I have read the contributing guidelines and the review checklist
• I have personally reviewed, understood, and tested every change in this PR

AI Disclosure

AI assistance was used for the reviewer-requested revisions and targeted verification.

Test plan

• Compiled the real libsolutil/LazyInit.h with only the Boost-dependent Assertions.h and Exceptions.h stubbed out, using clang++ -std=c++23 -Wall -Wextra -Werror.
• Verified that move assignment is unavailable, move construction still works and leaves the source empty, and a direct move-assignment expression fails to compile because the operator is deleted.
• The full test suite was not run locally because CMake and Boost test dependencies are unavailable in this environment.

[blishko]

I had another, deeper, look and it looks like the move assignment operator of LazyInit is not used anywhere in the codebase (not surprising given that it is buggy).
I currently don't see a reason to support it so I think a better fix is just to explicitly delete the move assignment operator.

[clonker]

We can't compile code that uses it thanks to -Werror. I agree with removing it.

[kediyalua]

We can't compile code that uses it thanks to -Werror. I agree with removing it.

Thanks @blishko and @clonker. I agree with removing the unused operator. I’ve changed LazyInit’s move assignment to = delete, replaced the previous test with a compile-time check, and force-pushed the revision as a single commit. I’ve also updated the PR description. Please take another look when you have a chance.

[clonker]

nice, thanks :)

all is addressed!