fix(core): align comments_ordered_by_submitted with STI base class - #2
Open
capy-ai[bot] wants to merge 1 commit into
Open
capy-ai[bot] wants to merge 1 commit into
capy-ai[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
comments_ordered_by_submittedto useself.class.base_class.nameinstead ofself.class.name. This fix ensures consistency withfind_comments_forandComment.build_from, which already use the base class name forcommentable_type. Without this change, comments on STI subclasses (e.g.,Article < Post) are stored with the base class type but queried by the subclass type, causing them to be missed.lib/acts_as_commentable_with_threading.rb:52to useself.class.base_class.namefind_comments_forandComment.build_from