Skip to content

Commit 5e1fc09

Browse files
arraypressclaude
andcommitted
Line the header up with the table under it
The indent was applied to the header and to the title section inside it, so it counted twice and the heading sat forty-four pixels in from the table it belongs to. It is the header's, once. core gives that h1 `margin: 0 .8rem 1rem` and `padding: 9px 0 4px` -- a box noticeably taller than its text and weighted to the bottom -- and align-items centres everything else against the box rather than against the word, which is what dropped the mark below the line it is meant to share. Zeroed in this variant. The mark is 24px against core's 23px heading. An em sized it against the section's 13px instead, which is why it came out small. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tk8y5eZa3CHVVSM6nVxsJw
1 parent 7d90dd7 commit 5e1fc09

1 file changed

Lines changed: 24 additions & 13 deletions

File tree

‎assets/css/field-kit.css‎

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1419,35 +1419,46 @@ li.field-kit__repeater-row {
14191419
what this exists to stop. The padding matches the .wrap the table below it
14201420
sits in, so the heading lines up with the list rather than starting a
14211421
couple of pixels to its left. */
1422-
.field-kit__page-header--left,
1422+
/* The indent is the header's, once. Applied to the header and the title
1423+
section alike it was counted twice, and the heading sat forty-four pixels
1424+
in from the table it belongs to. */
1425+
.field-kit__page-header--left {
1426+
padding: 8px 20px 0 22px;
1427+
text-align: left;
1428+
}
1429+
14231430
.field-kit__page-header--left .privacy-settings-title-section {
14241431
justify-content: flex-start;
1425-
gap: .5rem;
1426-
padding: 8px 20px 0 22px;
1432+
align-items: center;
1433+
gap: .6rem;
1434+
padding: 0;
14271435
text-align: left;
14281436
}
14291437

1438+
/* core gives this h1 `margin: 0 .8rem 1rem` and `padding: 9px 0 4px` -- a box
1439+
noticeably taller than its text and weighted to the bottom. align-items
1440+
centres everything else against that box rather than against the word, which
1441+
is what dropped the mark below the baseline it is meant to share. */
14301442
.field-kit__page-header--left h1 {
1431-
margin-left: 0;
1432-
margin-right: 0;
1443+
margin: 0;
1444+
padding: 0;
14331445
}
14341446

14351447
/* Sized against the heading it sits beside rather than the 40px a centred,
14361448
stacked header has room for. A mark twice the height of the word next to it
14371449
reads as a logo that has been dropped on the page rather than one that
14381450
belongs to the title. */
14391451
.field-kit__page-header--left .field-kit__page-logo {
1440-
max-height: 1.6em;
1441-
margin-right: 0;
1452+
/* core's heading here is 23px, and the mark reads as its equal at 24.
1453+
Not an em: the image inherits the section's 13px, not the h1's, so an
1454+
em sized it against the wrong thing and came out too small. */
1455+
height: 24px;
1456+
max-height: none;
1457+
width: auto;
1458+
margin: 0;
14421459
flex: 0 0 auto;
14431460
}
14441461

1445-
/* Centred on each other, so the mark, the heading and the button share a
1446-
line instead of each finding its own. */
1447-
.field-kit__page-header--left .privacy-settings-title-section {
1448-
align-items: center;
1449-
}
1450-
14511462
/* Beside the heading, and on its baseline rather than the flex line's. No
14521463
bottom margin: the row already carries a rem of bottom padding, and the
14531464
two together left the actions sitting a clear gap below the title they

0 commit comments

Comments
 (0)