Hand the type questions to the kit

is_setting_on(), is_setting_enabled() and the page helpers were never about
settings — they decide what a stored value means, and the same question is
asked of a term's meta, a user's meta and a post's meta. This library had
eleven of them and the other three had none, which is the shape of something
that belongs one level down. They read the value and delegate; the kit's
Value class answers.

Two of them were also wrong. is_setting_field_page() called is_page(), which
answers false for every post type that is not a page even though the kit's
post, page and ajax types all store an id the same way — it compares the
queried object now. And Page.php carried TypeCheck.php's docblock, so both
files claimed to be about toggles and multi-selects.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tk8y5eZa3CHVVSM6nVxsJw

Author: arraypress

src/SettingFields.php

@@ -1191,8 +1191,11 @@ public function get_field( string $field_key ): ?array {
 	/**
 	 * Tell the kit which configuration this library reads.
 	 *
-	 * Which tab and which section of this page a field belongs to. Both are about the page's layout rather than the field, so they are read here. Without this the kit reports each one as configuration
-	 * nothing reads, which is exactly the warning it exists to give.
+	 * Which tab and which section of this page a field belongs to. Both are
+	 * about the page's layout rather than the field, so they are read here.
+	 * Without this the kit would report each of them as configuration
+	 * nothing reads — which is the warning it exists to give, aimed at the
+	 * wrong thing.
 	 *
 	 * @return void
 	 */

src/Utilities/Page.php

@@ -1,15 +1,17 @@
 <?php
 /**
- * Type Check Helper Functions
+ * Page Field Helper Functions
  *
- * Convenience functions for checking toggle, multi-select, and page field values.
+ * Convenience functions for the page/post a setting points at.
  *
  * @package     ArrayPress\RegisterSettingFields
- * @copyright   Copyright (c) 2025, ArrayPress Limited
+ * @copyright   Copyright (c) 2026, ArrayPress Limited
  * @license     GPL2+
  * @since       1.0.0
  */
 
+use ArrayPress\FieldKit\Value;
+
 /** Page Field Helpers ********************************************************/
 
 if ( ! function_exists( 'get_setting_field_page_id' ) ) {
@@ -22,7 +24,7 @@
 	 * @return int Page/post ID or 0 if not set.
 	 */
 	function get_setting_field_page_id( string $settings_id, string $field_key ): int {
-		return absint( get_setting_field_value( $settings_id, $field_key, 0 ) );
+		return Value::id( get_setting_field_value( $settings_id, $field_key, 0 ) );
 	}
 }
 
@@ -34,39 +36,28 @@ function get_setting_field_page_id( string $settings_id, string $field_key ): in
 	 * @param string $field_key   Field key.
 	 * @param string $fallback    Fallback URL if page not set.
 	 *
-	 * @return string Page URL or fallback.
+	 * @return string Page URL, the fallback, or the site's home page.
 	 */
 	function get_setting_field_page_url( string $settings_id, string $field_key, string $fallback = '' ): string {
-		$page_id = get_setting_field_page_id( $settings_id, $field_key );
-
-		if ( $page_id > 0 ) {
-			$url = get_permalink( $page_id );
-
-			if ( $url ) {
-				return $url;
-			}
-		}
-
-		return $fallback ?: home_url( '/' );
+		return Value::url( get_setting_field_value( $settings_id, $field_key, 0 ), $fallback );
 	}
 }
 
 if ( ! function_exists( 'is_setting_field_page' ) ) {
 	/**
 	 * Check if currently viewing the page stored in a setting field.
 	 *
+	 * Compares the queried object rather than calling is_page(): a setting
+	 * can point at any post type — the kit's `post`, `page` and `ajax` types
+	 * all store an id the same way — and is_page() answers false for every
+	 * one of them that is not a page, which this used to get wrong.
+	 *
 	 * @param string $settings_id Settings ID.
 	 * @param string $field_key   Field key.
 	 *
 	 * @return bool
 	 */
 	function is_setting_field_page( string $settings_id, string $field_key ): bool {
-		if ( ! is_singular() ) {
-			return false;
-		}
-
-		$page_id = get_setting_field_page_id( $settings_id, $field_key );
-
-		return $page_id > 0 && is_page( $page_id );
+		return Value::is_viewing( get_setting_field_value( $settings_id, $field_key, 0 ) );
 	}
 }

src/Utilities/TypeCheck.php

@@ -2,14 +2,23 @@
 /**
  * Type Check Helper Functions
  *
- * Convenience functions for checking toggle, multi-select, and page field values.
+ * Convenience functions for asking what a stored setting means.
  *
  * @package     ArrayPress\RegisterSettingFields
- * @copyright   Copyright (c) 2025, ArrayPress Limited
+ * @copyright   Copyright (c) 2026, ArrayPress Limited
  * @license     GPL2+
  * @since       1.0.0
  */
 
+use ArrayPress\FieldKit\Value;
+
+/*
+ * What a value means is the kit's answer, not this library's: the same
+ * question is asked of a term's meta, a user's meta and a post's meta, and
+ * four copies of "is this on" would draw the line in four slightly different
+ * places. These read the value and hand it over.
+ */
+
 /** Toggle & Multi-Select Helpers *********************************************/
 
 if ( ! function_exists( 'is_setting_on' ) ) {
@@ -22,10 +31,7 @@
 	 * @return bool
 	 */
 	function is_setting_on( string $settings_id, string $field_key ): bool {
-		return filter_var(
-			get_setting_field_value( $settings_id, $field_key, false ),
-			FILTER_VALIDATE_BOOLEAN
-		);
+		return Value::is_on( get_setting_field_value( $settings_id, $field_key, false ) );
 	}
 }
 
@@ -40,8 +46,34 @@ function is_setting_on( string $settings_id, string $field_key ): bool {
 	 * @return bool
 	 */
 	function is_setting_enabled( string $settings_id, string $field_key, string $option ): bool {
-		$value = get_setting_field_value( $settings_id, $field_key, [] );
+		return Value::includes( get_setting_field_value( $settings_id, $field_key, [] ), $option );
+	}
+}
+
+if ( ! function_exists( 'get_setting_field_list' ) ) {
+	/**
+	 * Get a tags or multi-select field as a list of strings.
+	 *
+	 * @param string $settings_id Settings ID.
+	 * @param string $field_key   Field key.
+	 *
+	 * @return string[]
+	 */
+	function get_setting_field_list( string $settings_id, string $field_key ): array {
+		return Value::list( get_setting_field_value( $settings_id, $field_key, [] ) );
+	}
+}
 
-		return is_array( $value ) && in_array( $option, $value, true );
+if ( ! function_exists( 'get_setting_field_ids' ) ) {
+	/**
+	 * Get a relational field as a list of object ids.
+	 *
+	 * @param string $settings_id Settings ID.
+	 * @param string $field_key   Field key.
+	 *
+	 * @return int[]
+	 */
+	function get_setting_field_ids( string $settings_id, string $field_key ): array {
+		return Value::ids( get_setting_field_value( $settings_id, $field_key, [] ) );
 	}
 }

tests/SettingFieldsTest.php

@@ -1041,4 +1041,37 @@ private function import( array $payload ): void {
 			unset( $redirect );
 		}
 	}
+
+	/**
+	 * The type helpers read through the page and answer through the kit.
+	 *
+	 * They used to hold their own idea of what "on" means. Four libraries
+	 * were on their way to four of those, so the answer moved to the kit and
+	 * these became the reading half — which is the half that is about
+	 * settings.
+	 */
+	public function test_the_type_helpers_delegate(): void {
+		$page = $this->page(
+			[
+				'fields' => [
+					'flag'     => [ 'type' => 'toggle' ],
+					'features' => [
+						'type'    => 'checkbox_group',
+						'options' => [ 'a' => 'A', 'b' => 'B' ],
+					],
+				],
+			]
+		);
+
+		update_option( $page->get_option_name(), [ 'flag' => '1', 'features' => [ 'a' ] ] );
+
+		$this->assertTrue( is_setting_on( $page->get_id(), 'flag' ) );
+		$this->assertTrue( is_setting_enabled( $page->get_id(), 'features', 'a' ) );
+		$this->assertFalse( is_setting_enabled( $page->get_id(), 'features', 'b' ) );
+
+		// The case a plain (bool) cast gets backwards.
+		update_option( $page->get_option_name(), [ 'flag' => '0' ] );
+		$this->assertFalse( is_setting_on( $page->get_id(), 'flag' ) );
+	}
+
 }